Quentin LAMBERT
Author's posts
Aug 18 2014
iommu: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 18 2014
tcm_fc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 17 2014
net/openvswitch/flow.c: Replace rcu_dereference() with rcu_access_pointer()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The “rcu_dereference()” call is used directly in a condition. Since its return value is never dereferenced it is recommended to use “rcu_access_pointer()” instead of “rcu_dereference()”. Therefore, this patch makes the replacement. The following Coccinelle semantic patch was used: @@ @@ ( if( ()) {…} | while( ()) {…} ) Signed-off-by: Andreea-Cristina …
Aug 17 2014
mac80211: Replace rcu_dereference() with rcu_access_pointer()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The “rcu_dereference()” calls are used directly in conditions. Since their return values are never dereferenced it is recommended to use “rcu_access_pointer()” instead of “rcu_dereference()”. Therefore, this patch makes the replacements. The following Coccinelle semantic patch was used: @@ @@ ( if( ()) {…} | while( ()) {…} ) Signed-off-by: Andreea-Cristina Bernat …
Aug 17 2014
net/ipv4/igmp.c: Replace rcu_dereference() with rcu_access_pointer()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The “rcu_dereference()” call is used directly in a condition. Since its return value is never dereferenced it is recommended to use “rcu_access_pointer()” instead of “rcu_dereference()”. Therefore, this patch makes the replacement. The following Coccinelle semantic patch was used: @@ @@ ( if( ()) {…} | while( ()) {…} ) Signed-off-by: Andreea-Cristina …
Aug 17 2014
bonding: Replace rcu_dereference() with rcu_access_pointer()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> This “rcu_dereference()” call is used directly in a condition. Since its return value is never dereferenced it is recommended to use “rcu_access_pointer()” instead of “rcu_dereference()”. Therefore, this patch makes this replacement. The following Coccinelle semantic patch was used for solving it: @@ @@ ( if( ()) {…} | while( ()) {…} …
Aug 17 2014
cnic: Replace rcu_dereference() with rcu_access_pointer()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The “rcu_dereference()” calls are used directly in conditions. Since their return values are never dereferenced it is recommended to use “rcu_access_pointer()” instead of “rcu_dereference()”. Therefore, this patch makes the replacements. The following Coccinelle semantic patch was used: @@ @@ ( if( ()) {…} | while( ()) {…} ) Signed-off-by: Andreea-Cristina Bernat …
Aug 17 2014
staging: comedi: dt3000: remove unneeded variable
Author: Chase Southwood <chase.southwood@gmail.com> Coccinelle (using scripts/coccinelle/tests/doublebitand.cocci) found this assignment because 0 is or’d twice. Upon inspection, I found that the variable “mode” is only assigned once and used once, and thus can be cleanly removed. This patch plugs its value straight into writew() and then removes the variable. Signed-off-by: Chase Southwood Reviewed-by: Ian Abbott …
Aug 17 2014
isdn/bas_gigaset: use USB API functions rather than constants
Author: Himangi Saraogi <himangi774@gmail.com> This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ – (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Acked-by: Tilman Schmidt Signed-off-by: David S. Miller — drivers/isdn/gigaset/bas-gigaset.c | 2 +- 1 file …
Aug 15 2014
isdn/gigaset: use USB API functions rather than constants
Author: Himangi Saraogi <himangi774@gmail.com> This patch introduces the use of the function usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ – (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Acked-by: Tilman Schmidt Signed-off-by: David S. Miller — drivers/isdn/gigaset/usb-gigaset.c | 2 +- 1 file …