Quentin LAMBERT
Author's posts
Mar 24 2014
chelsio: Remove addressof casts to same type
Author: Joe Perches <joe@perches.com> Using addressof then casting to the original type is pointless, so remove these unnecessary casts. Done via coccinelle script: $ cat typecast.cocci @@ type T; T foo; @@ – (T *)&foo + &foo Signed-off-by: Joe Perches Signed-off-by: David S. Miller — drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 …
Mar 20 2014
INTEL-IGB: Convert iounmap to pci_iounmap
Author: Peter Senna Tschudin <peter.senna@gmail.com> Use pci_iounmap instead of iounmap when the virtual mapping was done with pci_iomap. A simplified version of the semantic patch that finds this issue is as follows: (http://coccinelle.lip6.fr/) // @r@ expression addr; @@ addr = pci_iomap(…) @rr@ expression r.addr; @@ * iounmap(addr) // Signed-off-by: Peter Senna Tschudin Tested-by: Aaron Brown …
Mar 18 2014
staging: unisys: kmalloc/memset to kzalloc conversation
Author: Silvio F <silvio.fricke@gmail.com> This patch solves the Coccinelle warning: “kzalloc should be used instead of kmalloc/memset” This patch is a fixup for linux-next: 97a84f1203786985856a0d4b49b1d7cc387238ce “Staging: unisys: Replace kmalloc/memset with kzalloc” The ALLOC_CMDRSP #define is after transformation to kzalloc only a rename for kzalloc and was completly removed. Signed-off-by: Silvio F Signed-off-by: Greg Kroah-Hartman — …
Mar 18 2014
ATHEROS-ATL1E: Convert iounmap to pci_iounmap
Author: Peter Senna Tschudin <peter.senna@gmail.com> Use pci_iounmap instead of iounmap when the virtual mapping was done with pci_iomap. A simplified version of the semantic patch that finds this issue is as follows: (http://coccinelle.lip6.fr/) // @r@ expression addr; @@ addr = pci_iomap(…) @rr@ expression r.addr; @@ * iounmap(addr) // Signed-off-by: Peter Senna Tschudin Signed-off-by: David S. …
Mar 18 2014
staging: slicoss: free IO remapping on failure
Author: Kristina Martšenko <kristina.martsenko@gmail.com> Make sure iounmap is always called after ioremap when module loading fails. Also remove a call to release_mem_region because that region is never reserved in the first place. Fixes the following issue reported by Coccinelle: drivers/staging/slicoss/slicoss.c:3727:1-7: ERROR: missing iounmap; ioremap on line 3661 and execution via conditional on line 3677 Signed-off-by: …
Mar 17 2014
staging:vt6655: Fix sparse warnings of using plain integer as NULL pointer
Author: Himangi Saraogi <himangi774@gmail.com> This patch fixes the following sparse warnings: drivers/staging/vt6655/wmgr.c:970:42: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:971:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:972:38: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:973:43: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4110:37: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4111:41: warning: Using plain …
Mar 17 2014
Staging: solo6x10: Replace expressions that don’t use ALIGN macro
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> There are some expressions that compute the roundup of a number, but don’t use the existing macro defined in /include/kernel.h. This patch uses the following Coccinelle semantic patch: @ haskernel @ @@ @ depends on haskernel @ expression E1, E2; @@ – (E1 + (E2 – 1)) & ~(E2 – 1) …
Mar 16 2014
staging: r8188eu: fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:8030:3-9: Replace memcpy with struct assignment Generated by: coccinelle/misc/memcpy-assign.cocci Signed-off-by: Fengguang Wu Signed-off-by: Larry Finger Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index 21f2f87..3ed5941 100644 — a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c @@ -8030,7 +8030,7 @@ static int rtw_scan_ch_decision(struct adapter *padapter, …
Mar 15 2014
staging:keucr: Remove typedefs
Author: Himangi Saraogi <himangi774@gmail.com> As suggested by Pablo, this patch uses a coccinelle script to remove the typedefs: typedef u8 BOOLEAN;
Mar 14 2014
Staging: unisys: Replace kmalloc/memset with kzalloc
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> This patch solves the Coccinelle warning: “kzalloc should be used instead of kmalloc/memset”. Signed-off-by: Andreea-Cristina Bernat Signed-off-by: Peter P Waskiewicz Jr — drivers/staging/unisys/virthba/virthba.c | 4 ++– drivers/staging/unisys/virtpci/virtpci.c | 4 +— drivers/staging/unisys/visorchipset/parser.c | 4 ++– drivers/staging/unisys/visorchipset/visorchipset_main.c | 9 ++++—– drivers/staging/unisys/visorutil/memregion_direct.c | 4 ++– 5 files changed, 11 insertions(+), 14 deletions(-) diff …