Author's posts
Mar 04 2015
staging: rtl8192e: remove extra parentheses around right bit shift operation
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operation. The cases handled are when the resultant value is assigned to a variable or when a shift operation is carried out for a function argument. The issues were detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ …
Mar 04 2015
staging: rtl8188eu: remove extra parentheses around right bit shift operations
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operations. The cases handled here are when resultant values are assigned to variables. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant c; type …
Mar 04 2015
staging: media: lirc: remove extra parentheses around right bit shift operation
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operation. The case handled here is when the resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant …
Mar 04 2015
staging: media: bcm2048: remove extra parentheses around right bit shift operation
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operation. The case handled here is when the resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant …
Mar 04 2015
staging: lustre: llite: remove extra parentheses around right bit shift operation
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operation. The case handled here is when the resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant …
Mar 04 2015
staging: lustre: lclient: remove extra parentheses around right bit shift operation
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operations. The cases handled here are when the resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant …
Mar 04 2015
staging: comedi: drivers: remove extra parentheses around right bit shift operation
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operation. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant c; type t; expression e; @@ t i = -(e +e >> -c); +c; …
Mar 03 2015
Staging: rtl8712: Eliminate use of _init_timer
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of API function setup_timer instead of driver specific function _init_timer as it is the preferred and standard way to setup and set the timer. To be compatible with the change, argument types of referenced functions are changed. Also, definition of function _init_timer is removed as it …
Mar 03 2015
staging: lustre: remove initialization of static ints
Author: Supriya Karanth <iskaranth@gmail.com> static ints are initialized to 0 by the compiler. Explicit initialization is not necessary. Found by checkpatch.pl – ERROR: do not initialise statics to 0 or NULL changes made using coccinelle script: @@ type T; identifier var; @@ -static T var = 0; +static T var; Signed-off-by: Supriya Karanth Signed-off-by: Greg …
Mar 03 2015
staging: rtl8192u: ieee80211: replace memset(x,0,ETH_ALEN) by eth_zero_addr(x)
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The replacement was done by the following coccinelle script: @header@ @@ #include @eth_zero_addr@ expression e; @@ -memset(e,0,ETH_ALEN); +eth_zero_addr(e); @eth_broadcast_addr@ identifier e; @@ -memset(e,\(0xff\|0xFF\|255\),ETH_ALEN); +eth_broadcast_addr(e); @linux_header depends on !header && (eth_zero_addr || eth_broadcast_addr) @ …