Category: Linux

drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/b66399ed-278b-b85d-4a21-b34164936ef6@users.sourceforge.net — drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 8 ++—— 1 file changed, 2 insertions(+), 6 deletions(-) …

Continue reading

drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring — drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 8 ++—— 1 file changed, 2 insertions(+), 6 deletions(-)   diff –git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c …

Continue reading

drm/bochs: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/1e3a8c0d-e737-f092-727e-af7e3810b8dc@users.sourceforge.net — drivers/gpu/drm/bochs/bochs_mm.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) …

Continue reading

drm/msm: Delete an unnecessary check before drm_gem_object_unreference()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rob Clark — drivers/gpu/drm/msm/msm_gem.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-)   diff …

Continue reading

drm/msm: Delete unnecessary checks before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rob Clark — drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 3 +– drivers/gpu/drm/msm/msm_fb.c | 4 ++– drivers/gpu/drm/msm/msm_gem.c | 4 +— 3 …

Continue reading

drm/msm/hdmi: Delete an unnecessary check before the function call “kfree”

Author: Markus Elfring <elfring@users.sourceforge.net> The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rob Clark — drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff …

Continue reading

GPU-DRM-Radeon: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Alex Deucher — drivers/gpu/drm/radeon/radeon_display.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-)   diff …

Continue reading

cxl: Use for_each_compatible_node() macro

Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Use for_each_compatible_node() macro instead of open coding it. Generated by Coccinelle. Signed-off-by: Wei Yongjun Reviewed-by: Andrew Donnellan Acked-by: Ian Munsie Signed-off-by: Michael Ellerman — drivers/misc/cxl/base.c | 5 ++— 1 file changed, 2 insertions(+), 3 deletions(-)   diff –git a/drivers/misc/cxl/base.c b/drivers/misc/cxl/base.c index e6f49ac..2330980 100644 — a/drivers/misc/cxl/base.c +++ b/drivers/misc/cxl/base.c @@ -95,7 +95,7 @@ …

Continue reading

regulator: act8865: Fix missing of_node_put() in act8865_pdata_from_dt()

Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> This node pointer is returned by of_get_child_by_name() with refcount incremented in this function. of_node_put() is missing when exitting this function while invalid device type. Fix it by move of_get_child_by_name() code after device type check. Found by Coccinelle. Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown — drivers/regulator/act8865-regulator.c | 12 ++++++—— 1 file changed, …

Continue reading

drm/msm/hdmi: use PTR_ERR_OR_ZERO() to simplify the code

Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(…)) + PTR_ERR. Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Wei Yongjun Signed-off-by: Rob Clark — drivers/gpu/drm/msm/hdmi/hdmi.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-)   diff –git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 33bf52c..9737207 100644 — a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -537,10 +537,7 @@ static int msm_hdmi_register_audio_driver(struct hdmi *hdmi, struct device …

Continue reading