Category: Linux

s390/pci: Delete an unnecessary check before the function call “pci_dev_put”

Author: Markus Elfring <elfring@users.sourceforge.net> The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Martin Schwidefsky — arch/s390/pci/pci_event.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Continue reading

drm/amdgpu: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Reviewed-by: Christian König Signed-off-by: Markus Elfring Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 +— 1 file changed, 1 insertion(+), 3 …

Continue reading

drm/ast: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/f28c063f-ec56-e62b-9370-89ce833fa4e5@users.sourceforge.net — drivers/gpu/drm/ast/ast_main.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) …

Continue reading

drm/hdlcd: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_fbdev_cma_hotplug_event() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/c2b0f310-fa06-f4cc-0014-ea7f40564d26@users.sourceforge.net — drivers/gpu/drm/arm/hdlcd_drv.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) …

Continue reading

drm/cirrus: Delete an unnecessary check before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/bebf88d8-cc28-657a-e96c-58447d8cf376@users.sourceforge.net — drivers/gpu/drm/cirrus/cirrus_main.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) …

Continue reading

drm/tegra: Delete an unnecessary check before the function call “vunmap”

Author: Markus Elfring <elfring@users.sourceforge.net> The vunmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/b3fbdcaf-1bda-7ce9-935b-2d716727ec39@users.sourceforge.net — drivers/gpu/drm/tegra/fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c …

Continue reading

xprtrdma: fix semicolon.cocci warnings

Author: kbuild test robot <fengguang.wu@intel.com> net/sunrpc/xprtrdma/verbs.c:798:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Chuck Lever Signed-off-by: Fengguang Wu Reviewed-by: Chuck Lever Signed-off-by: Anna Schumaker — net/sunrpc/xprtrdma/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index a74d79d..536d0be 100644 — a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -765,7 +765,7 @@ rpcrdma_mr_recovery_worker(struct …

Continue reading

drm/virtgpu: Delete unnecessary checks before drm_gem_object_unreference_unlocked()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/5e3dafff-72bb-e616-e84a-368f78fa66b1@users.sourceforge.net — drivers/gpu/drm/virtio/virtgpu_display.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-) …

Continue reading

drm/arcpgu: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()

Author: Markus Elfring <elfring@users.sourceforge.net> The drm_fbdev_cma_hotplug_event() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/dd9a16b1-234c-6776-e6d9-943a8457334e@users.sourceforge.net — drivers/gpu/drm/arc/arcpgu_drv.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) …

Continue reading

drm/vc4: Delete unnecessary checks before two function calls

Author: Markus Elfring <elfring@users.sourceforge.net> The following functions test whether their argument is NULL and then return immediately. * drm_fbdev_cma_hotplug_event * drm_fbdev_cma_restore_mode Thus the tests around their calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/fb33d930-6a5c-c501-6676-26bd486f1cb5@users.sourceforge.net — drivers/gpu/drm/vc4/vc4_drv.c | 3 +– drivers/gpu/drm/vc4/vc4_kms.c | 3 …

Continue reading