Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Remove useless initialisation of variable whose value is reinitialised later. The Coccinelle semantic patch used to make this change is as follows: @@ type T; identifier x; constant C; expression e; @@ T x – = C ; x = e; Signed-off-by: Amitoj Kaur Chawla Signed-off-by: Takashi Iwai — sound/oss/ad1848.c …
Category: Linux
Jul 12 2016
drivers/amdgpu: Remove redundant itermediate return val
Author: Edward O’Callaghan <funfunctor@folklore1984.net> Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 6 ++—- drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 3 +– drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 6 ++—- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_processpptables.c | 3 +– drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 3 +– 5 files changed, 7 insertions(+), 14 deletions(-) diff –git a/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c index c0c9cc3..120a9e2 100644 …
Jul 12 2016
drivers/amdgpu: Use canonical boolean form in various predicates
Author: Edward O’Callaghan <funfunctor@folklore1984.net> V.2: Fixup by hand to remove a few instances of redundant ‘()’ left over. Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 6 +– drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 20 +++++— …/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 16 +++— drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 57 +++++++++++———– 5 …
Jul 12 2016
drivers/amdgpu: Remove redundant casts on kzalloc() calls
Author: Edward O’Callaghan <funfunctor@folklore1984.net> Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 2 +- …/drm/amd/powerplay/hwmgr/tonga_processpptables.c | 21 ++++++++————- 3 files changed, 10 insertions(+), 15 deletions(-) diff –git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c index 03b6128..27e0762 100644 — a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c @@ -534,7 +534,7 @@ …
Jul 12 2016
drivers/amdgpu: Remove redundant NULL check before kfree()
Author: Edward O’Callaghan <funfunctor@folklore1984.net> Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 +– drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 3 +– 2 files changed, 2 insertions(+), 4 deletions(-) diff –git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c index ee95e95..4cd857f 100644 — a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c @@ -1065,8 +1065,7 @@ static int amdgpu_cgs_acpi_eval_object(struct cgs_device …
Jul 12 2016
drivers/amdgpu: Use canonical form in branch predicates
Author: Edward O’Callaghan <funfunctor@folklore1984.net> Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 14 +++++++——- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 2 +- drivers/gpu/drm/amd/amdgpu/cik.c | 2 +- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff –git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c …
Jul 12 2016
drivers/amdgpu: Use ‘true/false’ for bool typed variables
Author: Edward O’Callaghan <funfunctor@folklore1984.net> Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/amdgpu/cz_dpm.c | 2 +- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/fiji_hwmgr.c | 4 +– …/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 40 +++++++++++———– 5 files changed, 25 insertions(+), 25 deletions(-) diff –git a/drivers/gpu/drm/amd/amdgpu/cz_dpm.c b/drivers/gpu/drm/amd/amdgpu/cz_dpm.c index 8ba07e7..2a11413 100644 …
Jul 12 2016
drivers/amdgpu: Remove spurious semicolons
Author: Edward O’Callaghan <funfunctor@folklore1984.net> Found-by: Coccinelle Signed-off-by: Edward O’Callaghan Reviewed-by: Tom St Denis Reviewed-by: Christian König Signed-off-by: Alex Deucher — drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/fiji_smc.c | 2 +- drivers/gpu/drm/amd/amdgpu/iceland_smc.c | 2 +- drivers/gpu/drm/amd/amdgpu/tonga_smc.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff –git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index 7dbe8d0..dd965f2 100644 — a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c …
Jul 10 2016
gpio: dwapb: add missing fwnode_handle_put() in dwapb_gpio_get_pdata()
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> fwnode_handle_put() should be used when terminating device_for_each_child_node() iteration with break or return to prevent stale device node references from being left behind. Generated by Coccinelle. Fixes: 4ba8cfa79f44 (“gpio: dwapb: convert device node to fwnode”) Signed-off-by: Wei Yongjun Signed-off-by: Linus Walleij — drivers/gpio/gpio-dwapb.c | 1 + 1 file changed, 1 insertion(+) …
Jul 09 2016
[media] mtk-vcodec: fix platform_no_drv_owner.cocci warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c:433:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab — drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 1 – 1 file changed, 1 deletion(-) diff –git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c …
