Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Acked-by: Benjamin Herrenschmidt Signed-off-by: Michael Ellerman — arch/powerpc/platforms/pseries/iommu.c | 3 +– …
Category: Linux
Aug 08 2014
powerpc/mpc5xxx: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: Michael Ellerman — arch/powerpc/sysdev/mpc5xxx_clocks.c | 3 +– 1 file changed, …
Aug 08 2014
powerpc/fsl: fsl_soc: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Acked-by: Benjamin Herrenschmidt Signed-off-by: Michael Ellerman — arch/powerpc/sysdev/fsl_soc.c | 3 +– …
Aug 08 2014
net: axienet: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Reviewed-by: Michal Simek Signed-off-by: David S. Miller — drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 …
Aug 08 2014
i2c: mpc: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: Wolfram Sang — drivers/i2c/busses/i2c-mpc.c | 3 +– 1 file changed, …
Aug 08 2014
usb: gadget: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert a zero return value on error to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } …
Aug 08 2014
drivers/net: Remove typedef axnet_dev_t
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for axnet_dev_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier …
Aug 08 2014
drivers/net: Remove typedefs pcnet_dev_t and hw_info_t
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedefs for pcnet_dev_t and hw_info_t. Also, the name of the structs is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the cases: …
Aug 08 2014
drivers/net: ethernet: Remove typedef for struct and enum
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure and enum types. This patch gets rid of the typedef for cardtype_t and local_info_t. Also, the names of the struct and enum are changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic …
Aug 07 2014
dm9000: Remove typedef board_info_t
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for board_info_t. Also, the name of the structs is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the cases: @tn@ identifier …
