Aug 08 2014

powerpc/pseries: delete unneeded test before of_node_put 

Author: Julia Lawall <Julia.Lawall@lip6.fr>

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression e;
@@

-if (e)
   of_node_put(e);
// 

Signed-off-by: Julia Lawall 
Acked-by: Benjamin Herrenschmidt 
Signed-off-by: Michael Ellerman 

---
 arch/powerpc/platforms/pseries/iommu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 
diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
index 49bcf7c..1cc3db9 100644
--- a/arch/powerpc/platforms/pseries/iommu.c
+++ b/arch/powerpc/platforms/pseries/iommu.c
@@ -574,8 +574,7 @@ static void pci_dma_bus_setup_pSeries(struct pci_bus *bus)
 	while (isa_dn && isa_dn != dn)
 		isa_dn = isa_dn->parent;
 
-	if (isa_dn_orig)
-		of_node_put(isa_dn_orig);
+	of_node_put(isa_dn_orig);
 
 	/* Count number of direct PCI children of the PHB. */
 	for (children = 0, tmp = dn->child; tmp; tmp = tmp->sibling)

qlambert