Quentin LAMBERT
Author's posts
Oct 23 2014
Staging: vme: devices: Use kasprintf
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch uses kasprintf which combines kmalloc and sprintf. kasprintf also takes care of the size calculation. This is done using Coccinelle. Semantic patch used is as follows: @@ expression a,flag; expression list args; statement S; @@ a = – \(kmalloc\|kzalloc\)(…,flag) + kasprintf (flag,args) – sprintf(a,args); Signed-off-by: Vaishali Thakkar Signed-off-by: Greg …
Oct 22 2014
iommu/msm: Deletion of unnecessary checks before clk_disable()
Author: SF Markus Elfring <elfring@users.sourceforge.net> A semantic patch approach was proposed with the subject “[PATCH with Coccinelle?] Deletion of unnecessary checks before specific function calls” on 2014-03-05. https://lkml.org/lkml/2014/3/5/344 http://article.gmane.org/gmane.comp.version-control.coccinelle/3513/ This patch pattern application was repeated with the help of the software “Coccinelle 1.0.0-rc22” on the source files for Linux 3.17.1. An extract of the automatically …
Oct 21 2014
staging: media: omap24xx: Use min_t instead of min
Author: Aybuke Ozdemir <aybuke.147@gmail.com> This patch focuses on fixing the following warning generated by checkpatch.pl for the file tcm825x.c: WARNİNG: min() should probably be min_t(u32, tgt_xclk, TCM825X_XCLK_MAX) The changes were applied using the following coccinelle rule: @@ expression e1, e2; typedef u32; @@ -tgt_xclk = min(e1, (u32)e2); +tgt_xclk = min_t(u32, e1, e2); Signed-off-by: Aybuke Ozdemir …
Oct 20 2014
staging: lustre: lustre: obdecho: expand the GOTO macro in echo_client.c
Author: Jiayi Ye <yejiayily@gmail.com> The GOTO macro is not standard in Linux. The following Coccinelle semantic patch was used to expand the GOTO macro. @@ identifier lbl; identifier rc; constant c; @@ – GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ – GOTO(lbl,rc); + rc; + goto lbl; Signed-off-by: Jiayi Ye Signed-off-by: Greg …
Oct 20 2014
staging: ft1000: ft1000-pcmcia: removed unused variable in ft1000_hw.c
Author: Jiayi Ye <yejiayily@gmail.com> Variable whose value is initialized but never used is unnecessary. The following Coccinelle semantic patch removed the unused variable. @e@ identifier i; position p; type T; @@ extern T i@p; @@ type T; identifier i; constant C; position p != e.p; @@ – T i@p; Signed-off-by: Jiayi Ye Signed-off-by: Greg Kroah-Hartman …
Oct 20 2014
Staging: lustre: Remove typedef ldlm_ns_hash_def_t
Author: Vaishali Thakkar <vthakkar1994@gmail.com> The linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for ldlm_ns_hash_def_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. This is done using Coccinelle. Semantic patch used to detect …
Oct 16 2014
spi/atmel: fix simple_return.cocci warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/spi/spi-atmel.c:1518:1-4: WARNING: end returns can be simpified and declaration on line 1514 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — drivers/spi/spi-atmel.c | 7 +—— 1 file changed, 1 insertion(+), 6 deletions(-) diff –git …
Oct 16 2014
ASoC: Intel: mrfld: fix semicolon.cocci warnings
Author: Fengguang Wu <fengguang.wu@intel.com> sound/soc/intel/sst-atom-controls.c:249:2-3: Unneeded semicolon sound/soc/intel/sst-atom-controls.c:289:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu Acked-by: Vinod Koul Signed-off-by: Mark Brown — sound/soc/intel/sst-atom-controls.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) diff –git a/sound/soc/intel/sst-atom-controls.c b/sound/soc/intel/sst-atom-controls.c index dcdeb28..309a8f3 100644 — a/sound/soc/intel/sst-atom-controls.c +++ b/sound/soc/intel/sst-atom-controls.c @@ -454,7 +454,7 @@ static int …
Oct 15 2014
crypto: qat – cleanup coccicheck warning – NULL check before freeing functions
Author: Bruce Allan <bruce.w.allan@intel.com> Analyzing with coccinelle MODE=report… Please check for false positives in the output before submitting a patch. When using “patch” mode, carefully review the patch before submitting it. drivers/crypto/qat/qat_dh895xcc/adf_isr.c:191:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing …
Oct 14 2014
fs/befs/btree.c: remove typedef befs_btree_node
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for befs_btree_node. The following Coccinelle semantic patch detects the case. @tn1@ type td; @@ typedef struct { … } td; @script:python tf@ td