Author's posts
Nov 06 2014
dmaengine: at_xdmac: fix semicolon.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> drivers/dma/at_xdmac.c:702:3-4: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu Signed-off-by: Vinod Koul — drivers/dma/at_xdmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4e9b023..155577b 100644 — a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -699,7 +699,7 @@ at_xdmac_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr, desc->lld.mbr_sa = …
Nov 06 2014
at86rf230: fix simple_return.cocci warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/net/ieee802154/at86rf230.c:1365:1-3: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Acked-by: Alexander Aring Signed-off-by: Marcel Holtmann — drivers/net/ieee802154/at86rf230.c | 6 +—– 1 file changed, 1 insertion(+), 5 deletions(-) diff –git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c index a3cc7d9..ebcbeb3 100644 …
Nov 03 2014
ALSA: emu10k1: Deletion of unnecessary checks before three function calls
Author: Markus Elfring <elfring@users.sourceforge.net> The functions kfree(), release_firmware() and snd_util_memhdr_free() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/emu10k1/emu10k1_main.c | 9 +++—— sound/pci/emu10k1/emufx.c | 3 +– 2 files …
Nov 02 2014
ceph, rbd: delete unnecessary checks before two function calls
Author: SF Markus Elfring <elfring@users.sourceforge.net> The functions ceph_put_snap_context() and iput() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring [idryomov@redhat.com: squashed rbd.c hunk, changelog] Signed-off-by: Ilya Dryomov — drivers/block/rbd.c | 3 +– fs/ceph/caps.c …
Oct 31 2014
Staging: rtl8188eu: Use put_unaligned_le32
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_le32. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ – tmp = cpu_to_le32(y); ? tmp = e @@ type T; identifier tmp; @@ – T tmp; …when != tmp Signed-off-by: …
Oct 31 2014
Staging: rtl8192u: Use put_unaligned_le16
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ – tmp = cpu_to_le16(y); ? tmp = e @@ type T; identifier tmp; @@ – T tmp; …when != tmp Here, …
Oct 31 2014
Staging: rtl8192e: Use put_unaligned_le16
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ – tmp = cpu_to_le16(y); ? tmp = e @@ type T; identifier tmp; @@ – T tmp; …when != tmp Here, …
Oct 31 2014
Staging: lustre: Use put_unaligned_le64
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_le64. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ – tmp = cpu_to_le64(y); ? tmp = e @@ type T; identifier tmp; @@ – T tmp; …when != tmp Signed-off-by: …
Oct 30 2014
staging: emxx_udc: use USB API functions rather than constants
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> This patch introduces the use of the functions usb_endpoint_type and usb_endpoint_num. The Coccinelle semantic patch that makes these changes is as follows: @@ struct usb_endpoint_descriptor *epd; @@ – (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) + usb_endpoint_num(epd) @@ struct usb_endpoint_descriptor *epd; @@ – (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\)) + usb_endpoint_type(epd) Build Tested it. Signed-off-by: Tapasweni Pathak Signed-off-by: …
Oct 30 2014
staging: rtl8188eu: os_dep: Used min_t instead of min
Author: Gulsah Kose <gulsah.1004@gmail.com> This patch fixes this checkpatch.pl warning: WARNING: min() should probably be min_t(int, req->essid_len, IW_ESSID_MAX_SIZE) by using this coccinelle script: @r@ identifier i; expression e1, e2; type t1, t2; @@ t1 i = – min((t2)e1, e2); + min_t(t2, e1, e2); Signed-off-by: Gulsah Kose Reviewed-by: Daniel Baluta Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | …