Author's posts
Jan 03 2015
sound: oss: Deletion of unnecessary checks before the function call “vfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/oss/pss.c | 2 +- sound/oss/trix.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff –git …
Jan 03 2015
ALSA: seq: Deletion of unnecessary checks before the function call “snd_midi_event_free”
Author: Markus Elfring <elfring@users.sourceforge.net> The snd_midi_event_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/core/seq/oss/seq_oss_midi.c | 6 ++—- sound/core/seq/seq_midi.c | 3 +– 2 files changed, 3 insertions(+), …
Jan 02 2015
mac802154: fix kbuild test robot warning
Author: Alexander Aring <alex.aring@gmail.com> This patch fixs the following kbuild test robot warning: coccinelle warnings: (new ones prefixed by >>) >> net/mac802154/cfg.c:53:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Alexander Aring Signed-off-by: Marcel Holtmann — net/mac802154/cfg.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-) diff –git a/net/mac802154/cfg.c b/net/mac802154/cfg.c index 7d31da5..5d9f68c 100644 — a/net/mac802154/cfg.c …
Dec 29 2014
ath10k: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Dec 29 2014
net: axienet: fix error return code
Author: Julia Lawall <julia.lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Dec 29 2014
adm8211: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Dec 29 2014
net: sun4i-emac: fix error return code
Author: Julia Lawall <julia.lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Dec 29 2014
myri10ge: fix error return code
Author: Julia Lawall <julia.lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Dec 29 2014
net: Xilinx: fix error return code
Author: Julia Lawall <julia.lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Dec 27 2014
PCI: Delete unnecessary NULL pointer checks
Author: Markus Elfring <elfring@users.sourceforge.net> The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Bjorn Helgaas — drivers/pci/hotplug/cpci_hotplug_core.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …