Author's posts
May 29 2015
staging: me_daq: use schedule_timeout_interruptible()
Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./drivers/staging/comedi/drivers/me_daq.c:177:1-17: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion of the current calls to an available helper only – so only an API consolidation to improve readability. Signed-off-by: Nicholas Mc Guire Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman — drivers/staging/comedi/drivers/me_daq.c | 3 +– 1 file …
May 29 2015
staging: unisys: use schedule_timeout_interruptible()
Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only – so only an API consolidation to improve readability. The hard coded timeout of 10 jiffies is HZ dependent which it should not be, so it …
May 29 2015
sound/oss: use schedule_timeout_interruptible()
Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./sound/oss/msnd_pinnacle.c:1292:2-18: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion of the current calls to an available helper only – so only an API consolidation to improve readability. Patch was compile tested with x86_64_defconfig Patch is against 4.1-rc5 (localversion-next is -next-20150529) Signed-off-by: Nicholas Mc Guire …
May 29 2015
regmap: drop unneeded goto
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Signed-off-by: Julia Lawall Signed-off-by: Mark Brown — drivers/base/regmap/regmap.c | …
May 29 2015
staging/lustre/mdc: drop unneeded goto
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/mdc/mdc_request.c | …
May 29 2015
wl1251: drop unneeded goto
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Signed-off-by: Julia Lawall Signed-off-by: Kalle Valo — drivers/net/wireless/ti/wl1251/acx.c | …
May 29 2015
NFS: drop unneeded goto
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Also drop the unnecessary ret variable. Signed-off-by: Julia Lawall …
May 29 2015
ipv6: drop unneeded goto
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Also remove the unnecessary ret variable. Signed-off-by: Julia Lawall …
May 28 2015
staging: xgifb: use arch_phys_wc_add() and ioremap_wc()
Author: Luis R. Rodriguez <mcgrof@suse.com> The same area used for ioremap() is used for the MTRR area. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap’d area is requested as …
May 27 2015
rcu: Change return type to bool
Author: Nicholas Mc Guire <hofrat@osadl.org> Type-checking coccinelle spatches are being used to locate type mismatches between function signatures and return values in this case this produced: ./kernel/rcu/srcu.c:271 WARNING: return of wrong type int != unsigned long, srcu_readers_active() returns an int that is the sum of per_cpu unsigned long but the only user is cleanup_srcu_struct() which …