Staging winbond: boolean negation and bitwise operation in wrong order
Author: Diego Liziero <diegoliz@gmail.com>
The semantic patch that makes this change is:
(http://www.emn.fr/x-info/coccinelle/)
@@ expression E; constant C; @@
(
- !E == C
+ E != C
)
Signed-off-by: Diego Liziero
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/winbond/mds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
index c7af092..59d6d67 100644
--- a/drivers/staging/winbond/mds.c
+++ b/drivers/staging/winbond/mds.c
@@ -432,7 +432,7 @@ Mds_Tx(struct wbsoft_priv * adapter)
return;
//Only one thread can be run here
- if (!atomic_inc_return(&pMds->TxThreadCount) == 1)
+ if (atomic_inc_return(&pMds->TxThreadCount) != 1)
goto cleanup;
// Start to fill the data |
---
drivers/staging/winbond/mds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
index c7af092..59d6d67 100644
--- a/drivers/staging/winbond/mds.c
+++ b/drivers/staging/winbond/mds.c
@@ -432,7 +432,7 @@ Mds_Tx(struct wbsoft_priv * adapter)
return;
//Only one thread can be run here
- if (!atomic_inc_return(&pMds->TxThreadCount) == 1)
+ if (atomic_inc_return(&pMds->TxThreadCount) != 1)
goto cleanup;
// Start to fill the data