Category: Linux

ALSA: dummy: constify dummy_timer_ops structures

Author: Julia Lawall <Julia.Lawall@lip6.fr> The dummy_timer_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Takashi Iwai — sound/drivers/dummy.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-)   diff –git a/sound/drivers/dummy.c b/sound/drivers/dummy.c index 016e451..75b7485 100644 — a/sound/drivers/dummy.c +++ b/sound/drivers/dummy.c @@ -351,7 +351,7 @@ …

Continue reading

iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

Author: Julia Lawall <Julia.Lawall@lip6.fr> The il_sensitivity_ranges is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Acked-by: Stanislaw Gruszka Signed-off-by: Kalle Valo — drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c index 6656215..fd38aa0 100644 — a/drivers/net/wireless/intel/iwlegacy/4965-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c @@ -6416,7 …

Continue reading

cpufreq-dt: fix handling regulator_get_voltage() result

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative values so it should be assigned to signed type. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci. Link: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki — drivers/cpufreq/cpufreq-dt.c | 5 +++– 1 file changed, 3 insertions(+), 2 deletions(-)   diff –git …

Continue reading

Staging: ste_rmi4: constify synaptics_rmi4_platform_data structures

Author: Julia Lawall <Julia.Lawall@lip6.fr> This synaptics_rmi4_platform_data structure is never modified, so declare it as const. Others are already const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c index 824d460..bbec0276 100644 — a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c …

Continue reading

ALSA: cs5535audio: constify cs5535audio_dma_ops structures

Author: Julia Lawall <Julia.Lawall@lip6.fr> The cs5535audio_dma_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Takashi Iwai — sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-)   diff –git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c index 9c2dc91..27fa57d 100644 — a/sound/pci/cs5535audio/cs5535audio_pcm.c +++ b/sound/pci/cs5535audio/cs5535audio_pcm.c @@ -402,7 +402,7 @@ …

Continue reading

xen/hvc: constify hv_ops structures

Author: Julia Lawall <Julia.Lawall@lip6.fr> These hv_ops structures are never modified, so declare them as const. Most were const already. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/tty/hvc/hvc_xen.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-)   diff –git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c index 1172542..f417fa1 100644 — a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c …

Continue reading

ALSA: atiixp: constify atiixp_dma_ops structures

Author: Julia Lawall <Julia.Lawall@lip6.fr> The atiixp_dma_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Takashi Iwai — sound/pci/atiixp.c | 6 +++— sound/pci/atiixp_modem.c | 4 ++– 2 files changed, 5 insertions(+), 5 deletions(-)   diff –git a/sound/pci/atiixp.c b/sound/pci/atiixp.c index 1028fc8..2ce0022 100644 — a/sound/pci/atiixp.c +++ b/sound/pci/atiixp.c …

Continue reading

mmc: sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection

Author: Markus Elfring <elfring@users.sourceforge.net> This issue was detected by using the Coccinelle software. Two pointer checks could be repeated by the sdricoh_init_mmc() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. * This implementation detail could be improved by adjustments for jump targets …

Continue reading

[media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc()

Author: Markus Elfring <elfring@users.sourceforge.net> This issue was detected by using the Coccinelle software. Return the value from a call of the msi2500_ctrl_msg() function without using an extra check for the variable “ret” at the end. Signed-off-by: Markus Elfring Signed-off-by: Mauro Carvalho Chehab — drivers/media/usb/msi2500/msi2500.c | 2 — 1 file changed, 2 deletions(-)   diff –git …

Continue reading

[media] au0828: Refactoring for start_urb_transfer()

Author: Markus Elfring <elfring@users.sourceforge.net> This issue was detected by using the Coccinelle software. 1. Let us return directly if a buffer allocation failed. 2. Delete the jump label “err” then. 3. Drop the explicit initialisation for the variable “ret” at the beginning. 4. Return zero as a constant at the end. Signed-off-by: Markus Elfring Signed-off-by: …

Continue reading