Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> The dereference should be moved below the NULL test. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman — drivers/tty/serial/ioc3_serial.c | 3 ++- drivers/tty/serial/ioc4_serial.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff –git a/drivers/tty/serial/ioc3_serial.c b/drivers/tty/serial/ioc3_serial.c index 758ff310..5ac5289 100644 — …
Category: Linux
Sep 07 2012
RDMA/cxgb4: Move dereference below NULL test
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Acked-by: Steve Wise Signed-off-by: Roland Dreier — drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 51f4206..6cfd4d8 100644 — a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c @@ -1361,11 +1361,11 @@ static int abort_rpl(struct …
Sep 06 2012
drivers/net/wireless/rtlwifi/rtl8192de/phy.c: removes unnecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Acked-by: Larry Finger Signed-off-by: John W. Linville — drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c index 4420312..db00860 100644 — a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c @@ -1314,7 +1314,7 @@ static void _rtl92d_phy_restore_rf_env(struct ieee80211_hw …
Sep 06 2012
net/mac80211/scan.c: removes unnecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Johannes Berg — net/mac80211/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/net/mac80211/scan.c b/net/mac80211/scan.c index e9b1929..c4cdbde 100644 — a/net/mac80211/scan.c +++ b/net/mac80211/scan.c @@ -407,7 +407,7 @@ static void ieee80211_scan_state_send_probe(struct ieee80211_local *local, enum ieee80211_band band …
Sep 06 2012
drivers/video/sis/initextlfb.c: removes unnecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Florian Tobias Schandinat — drivers/video/sis/initextlfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/video/sis/initextlfb.c b/drivers/video/sis/initextlfb.c index 9dec64d..3ab18f5 100644 — a/drivers/video/sis/initextlfb.c +++ b/drivers/video/sis/initextlfb.c @@ -65,7 +65,7 @@ sisfb_mode_rate_to_dclock(struct SiS_Private *SiS_Pr, unsigned char modeno, } …
Sep 06 2012
[media] drivers/media/usb/gspca/cpia1.c: fix error return code
Author: Peter Senna Tschudin <peter.senna@gmail.com> Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... …
Sep 06 2012
[media] drivers/media/platform/soc_camera/soc_camera.c: fix error return code
Author: Peter Senna Tschudin <peter.senna@gmail.com> Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... …
Sep 06 2012
[media] drivers/media/pci/cx88/cx88-blackbird.c: removes unnecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Mauro Carvalho Chehab — drivers/media/pci/cx88/cx88-blackbird.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/drivers/media/pci/cx88/cx88-blackbird.c b/drivers/media/pci/cx88/cx88-blackbird.c index def363f..62184eb 100644 — a/drivers/media/pci/cx88/cx88-blackbird.c +++ b/drivers/media/pci/cx88/cx88-blackbird.c @@ -721,7 +721,7 @@ static int vidioc_g_fmt_vid_cap (struct file *file, void …
Sep 06 2012
[media] drivers/media/dvb-frontends/itd1000.c: removes unnecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Mauro Carvalho Chehab — drivers/media/dvb-frontends/itd1000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/media/dvb-frontends/itd1000.c b/drivers/media/dvb-frontends/itd1000.c index 3164575..c1c3400 100644 — a/drivers/media/dvb-frontends/itd1000.c +++ b/drivers/media/dvb-frontends/itd1000.c @@ -231,7 +231,7 @@ static void itd1000_set_lo(struct itd1000_state *state, u32 freq_khz) …
Sep 06 2012
[media] drivers/media/dvb-frontends/sp8870.c: removes unnecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Mauro Carvalho Chehab — drivers/media/dvb-frontends/sp8870.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c index e37274c..2aa8ef7 100644 — a/drivers/media/dvb-frontends/sp8870.c +++ b/drivers/media/dvb-frontends/sp8870.c @@ -188,7 +188,7 @@ static int configure_reg0xc05 (struct dtv_frontend_properties *p, u16 …