Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert the composition of devm_request_mem_region and devm_ioremap to a single call to devm_ioremap_resource. The associated call to platform_get_resource is also simplified and moved next to the new call to devm_ioremap_resource. This was done using a combination of the semantic patches devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in the scripts/coccinelle/api directory. This patch also …
Category: Linux
Aug 20 2013
brcmsmac: use ARRAY_SIZE in phytbl_lcn.c
Author: Arend van Spriel <arend@broadcom.com> This patch converts all sizeof(x)/sizeof(x[0]) instances to ARRAY_SIZE macro in phytbl_lcn.c. The patch was made using spatch with ARRAY_SIZE.cocci (see [1]). [1] https://github.com/coccinelle/coccinelle/tree/master/demos/janitorings Cc: Jonas Gorski Tested-by: David Herrmann Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel Signed-off-by: John W. Linville — …/wireless/brcm80211/brcmsmac/phy/phytbl_lcn.c | 117 ++++++++————- 1 file …
Aug 19 2013
usb: musb: dsps: fix devm_ioremap_resource error detection code
Author: Julia Lawall <Julia.Lawall@lip6.fr> devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. Furthermore, the value returned by devm_ioremap_resource should be tested. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(…); if (!e1) S // Signed-off-by: Julia Lawall Signed-off-by: …
Aug 19 2013
video: xilinxfb: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci The initialization of drvdata->regs_phys was manually moved lower, to take advantage of the NULL test on res performed by devm_ioremap_resource. Signed-off-by: Julia Lawall Signed-off-by: Tomi Valkeinen — drivers/video/xilinxfb.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-) …
Aug 19 2013
bcm63xx_enet: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci The relevant call to platform_get_resource was manually moved down to the call to devm_ioremap_resource. Signed-off-by: Julia Lawall Signed-off-by: David S. Miller — drivers/net/ethernet/broadcom/bcm63xx_enet.c | 10 +++++—– 1 file changed, 5 insertions(+), 5 deletions(-) diff –git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c …
Aug 19 2013
dma: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci The relevant call to platform_get_resource was manually moved down to the call to devm_ioremap_resource. Signed-off-by: Julia Lawall Signed-off-by: Vinod Koul — drivers/dma/sh/sudmac.c | 10 +++++—– 1 file changed, 5 insertions(+), 5 deletions(-) diff –git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c index …
Aug 19 2013
iommu/arm-smmu: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was partly done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci The error-handling code on the call to platform_get_resource was removed manually, and the initialization of smmu->size was manually moved lower, to take advantage of the NULL test on res performed by devm_ioremap_resource. Signed-off-by: Julia Lawall Signed-off-by: Will …
Aug 19 2013
serial: st-asc: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci and various manual modifications to move associated calls to platform_get_resource closer to the resulting call to devm_ioremap_resource and to remove the associated error handling code. The initialization of port->mapbase is also moved lower, to take advantage of the …
Aug 19 2013
MIPS: ath79: simplify platform_get_resource_byname/devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Remove unneeded error handling on the result of a call to platform_get_resource_byname when the value is passed to devm_ioremap_resource. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression pdev,res,e,e1; expression ret != 0; identifier l; @@ res = platform_get_resource_byname(…); – if (res …
Aug 19 2013
regulator: ti-abb: simplify platform_get_resource_byname/devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Remove unneeded error handling on the result of a call to platform_get_resource_byname when the value is passed to devm_ioremap_resource. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression pdev,res,e,e1; expression ret != 0; identifier l; @@ res = platform_get_resource_byname(…); – if (res …