Author: Roberta Dobrescu <roberta.dobrescu@gmail.com> This patch removes uneeded return variables, using only ‘return _SUCCESS’ instead. It fixes the following warning detected by coccinelle: Unneeded variable. It was done using the following semantic patch: @@ identifier ret; type T; expression e; @@ -T ret = e; … when != ret when strict -return ret; +return e; …
Category: Linux
Oct 26 2014
staging: rtl8723au: os_dep: Remove uneeded return variable
Author: Roberta Dobrescu <roberta.dobrescu@gmail.com> This patch removes uneeded return variables, using only ‘return _SUCCESS’ instead. It fixes the following warning detected by coccinelle: Unneeded variable. It was done using the following semantic patch: @@ identifier ret; type T; expression e; @@ -T ret = e; … when != ret when strict -return ret; +return e; …
Oct 26 2014
staging: rtl8723au: hal: Remove uneeded return variable
Author: Roberta Dobrescu <roberta.dobrescu@gmail.com> This patch removes uneeded return variables, just using ‘return _SUCCESS’ or ‘return HCI_STATUS_SUCCESS’ instead. This fixes the following warning detected using coccinelle: Unneeded variable. It was done using the following semantic patch: @@ identifier ret; type T; expression e; @@ -T ret = e; … when != ret when strict -return …
Oct 26 2014
staging: rtl8723au: Remove uneeded semicolon
Author: Roberta Dobrescu <roberta.dobrescu@gmail.com> This patch fixes the following warning detected using coccinelle: Unneeded semicolon. Signed-off-by: Roberta Dobrescu Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8723au/core/rtw_ap.c | 2 +- drivers/staging/rtl8723au/core/rtw_recv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c index d00255f..e394d12 100644 — a/drivers/staging/rtl8723au/core/rtw_ap.c +++ b/drivers/staging/rtl8723au/core/rtw_ap.c @@ -636,7 +636,7 @@ static void …
Oct 26 2014
staging: rtl8723au: Do not use comparisons on bool tests
Author: Roberta Dobrescu <roberta.dobrescu@gmail.com> This patch removes unnecessary comparisons to bool. It fixes the following warning detected using coccinelle tool: WARNING: Comparison to bool. Signed-off-by: Roberta Dobrescu Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8723au/core/rtw_ap.c | 2 +- drivers/staging/rtl8723au/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +- …
Oct 26 2014
staging: rtl8188eu: core: Remove redundant memset before memcpy
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> The region set by the call to memset, immediately overwritten by the subsequent call to memcpy makes the memset redundant. This patch removes the redundant memset before memcpy using the following coccinelle script: @@ expression e1,e2,e3,e4; @@ – memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by: Tapasweni Pathak Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 1 – …
Oct 25 2014
staging: rtl8723au: delete successive assignments to the same location
Author: Jiayi Ye <yejiayily@gmail.com> Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( ()=e2; | ()=e2; | ()=e2; | ()=e2; | e1=e2; e1 = ; | *e1=e2; *e1=e3; ) Signed-off-by: Jiayi Ye Reviewed-by: Josh Triplett Signed-off-by: Greg Kroah-Hartman …
Oct 25 2014
staging: rtl8192u: delete successive assignments to the same location
Author: Jiayi Ye <yejiayily@gmail.com> Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( ()=e2; | ()=e2; | ()=e2; | ()=e2; | e1=e2; e1 = ; | *e1=e2; *e1=e3; ) Signed-off-by: Jiayi Ye Reviewed-by: Josh Triplett Signed-off-by: Greg Kroah-Hartman …
Oct 25 2014
staging: rtl8192e: delete successive assignments to the same location
Author: Jiayi Ye <yejiayily@gmail.com> Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( ()=e2; | ()=e2; | ()=e2; | ()=e2; | e1=e2; e1 = ; | *e1=e2; *e1=e3; ) Signed-off-by: Jiayi Ye Reviewed-by: Josh Triplett Signed-off-by: Greg Kroah-Hartman …
Oct 25 2014
staging: dgnc: delete successive assignments to the same location
Author: Jiayi Ye <yejiayily@gmail.com> Successive assignments to the same location is meaningless and can be deleted. The Coccinelle semantic patch was used to find cases. @@ expression e1,e2,e3; @@ ( ()=e2; | ()=e2; | ()=e2; | ()=e2; | e1=e2; e1 = ; | *e1=e2; *e1=e3; ) Signed-off-by: Jiayi Ye Reviewed-by: Josh Triplett Signed-off-by: Greg Kroah-Hartman …
