Category: Linux

ASoC: Remove codec field from snd_soc_dapm_widget

Author: Lars-Peter Clausen <lars@metafoo.de> There are no more users of this field left so it can finally be removed. New users should use snd_soc_dapm_to_codec(w->dapm); The reason why it is removed is because it doesn’t fit to well anymore in the componentized ASoC hierarchy, where DAPM works on the snd_soc_component level. And the alternative of snd_soc_dapm_to_codec(w->dapm) …

Continue reading

PCI: keystone: Fix misspelling of current function in debug output

Author: Julia Lawall <Julia.Lawall@lip6.fr> Replace a misspelled function name by %s and then __func__. The function name contains pcie, not pci as in the string. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall Signed-off-by: Bjorn Helgaas Acked-by: Murali Karicheri — drivers/pci/host/pci-keystone.c | 2 +- …

Continue reading

xhci-mem: Use setup_timer

Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert a call to init_timer and accompanying intializations of the timer’s data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression t,f,d; @@ -init_timer(&t); +setup_timer(&t,f,d); -t.data = d; -t.function = f; // Signed-off-by: Julia …

Continue reading

xhci: Use setup_timer

Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert a call to init_timer and accompanying intializations of the timer’s data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression t,f,d; @@ -init_timer(&t); +setup_timer(&t,f,d); -t.data = d; -t.function = f; // Signed-off-by: Julia …

Continue reading

ASoC: wm5102: Use put_unaligned_be16

Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_be16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16, __be16, uint16_t; {u16,__be16,uint16_t} e16; identifier tmp; expression ptr; expression y,e; type T; @@ – tmp = cpu_to_be16(y); ? tmp = e @@ type T; identifier a.tmp; @@ – …

Continue reading

ALSA: Deletion of checks before the function call “iounmap”

Author: Markus Elfring <elfring@users.sourceforge.net> The iounmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/aoa/soundbus/i2sbus/core.c | 13 ++++++——- sound/arm/aaci.c | 4 ++– sound/drivers/ml403-ac97cr.c | 3 +– sound/isa/msnd/msnd_pinnacle.c | 3 +– sound/parisc/harmony.c | …

Continue reading

ALSA: sb: Delete an unnecessary check before the function call “snd_emux_free”

Author: Markus Elfring <elfring@users.sourceforge.net> The snd_emux_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/isa/sb/emu8000_synth.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Continue reading

ALSA: aoa: Delete an unnecessary check before the function call “snd_pcm_suspend_all”

Author: Markus Elfring <elfring@users.sourceforge.net> The snd_pcm_suspend_all() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/aoa/soundbus/i2sbus/core.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-)   diff …

Continue reading

ASoC: Intel: Delete an unnecessary check before the function call “release_firmware”

Author: Markus Elfring <elfring@users.sourceforge.net> The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Mark Brown — sound/soc/intel/sst/sst_loader.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Continue reading

ASoC: fsi: Deletion of unnecessary checks before the function call “clk_enable”

Author: Markus Elfring <elfring@users.sourceforge.net> The clk_enable() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Mark Brown — sound/soc/sh/fsi.c | 9 +++—— 1 file changed, 3 insertions(+), 6 deletions(-)   diff …

Continue reading