Quentin LAMBERT
Author's posts
Jan 16 2015
brcmfmac: Use put_unaligned_le32
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_le32. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u32, __le32, uint32_t; {u32,__le32,uint32_t} e32; identifier tmp; expression ptr; expression y,e; type T; type T; @@ – tmp = cpu_to_le32(y); ? tmp = e @@ type T; identifier a.tmp; …
Jan 16 2015
IB/qib: Replace rcu_assign_pointer() with RCU_INIT_POINTER() in qib_keys.c
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The uses of “rcu_assign_pointer()” are NULLing out the pointers. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Jan 16 2015
IB/qib: Replace rcu_assign_pointer() with RCU_INIT_POINTER() in qib_qp.c
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> According to RCU_INIT_POINTER()’s block comment 3.a, it can be used if “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. “3. The referenced data structure has already been exposed to readers either at compile time …
Jan 16 2015
s390/net: Delete useless checks before function calls
Author: Markus Elfring <elfring@users.sourceforge.net> The function debug_unregister() tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Ursula Braun Signed-off-by: David S. Miller — drivers/s390/net/claw.c | 6 ++—- drivers/s390/net/lcs.c | 6 ++—- drivers/s390/net/netiucv.c …
Jan 16 2015
can: dev: fix semicolon.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> drivers/net/can/dev.c:294:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Cc: Andri Yngvason Signed-off-by: Fengguang Wu Signed-off-by: Marc Kleine-Budde — drivers/net/can/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index e54dbc1a..6ac02c8 100644 — a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -293,7 +293,7 @@ static void can_update_state_error_stats(struct net_device …
Jan 15 2015
drm/i915: Rename struct intel_crtc_config to intel_crtc_state
Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> The objective is to make this structure usable with the atomic helpers, so let’s start with the rename. Patch generated with coccinelle: @@ @@ -struct intel_crtc_config { +struct intel_crtc_state { … } @@ @@ -struct intel_crtc_config +struct intel_crtc_state v2: Completely generate the patch with cocci. (Ander) Signed-off-by: Ander Conselvan …
Jan 15 2015
ASoC: Remove codec field from snd_soc_dapm_widget
Author: Lars-Peter Clausen <lars@metafoo.de> There are no more users of this field left so it can finally be removed. New users should use snd_soc_dapm_to_codec(w->dapm); The reason why it is removed is because it doesn’t fit to well anymore in the componentized ASoC hierarchy, where DAPM works on the snd_soc_component level. And the alternative of snd_soc_dapm_to_codec(w->dapm) …
Jan 09 2015
PCI: keystone: Fix misspelling of current function in debug output
Author: Julia Lawall <Julia.Lawall@lip6.fr> Replace a misspelled function name by %s and then __func__. The function name contains pcie, not pci as in the string. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall Signed-off-by: Bjorn Helgaas Acked-by: Murali Karicheri — drivers/pci/host/pci-keystone.c | 2 +- …
Jan 09 2015
xhci-mem: Use setup_timer
Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert a call to init_timer and accompanying intializations of the timer’s data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression t,f,d; @@ -init_timer(&t); +setup_timer(&t,f,d); -t.data = d; -t.function = f; // Signed-off-by: Julia …
Jan 09 2015
xhci: Use setup_timer
Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert a call to init_timer and accompanying intializations of the timer’s data and function fields to a call to setup_timer. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression t,f,d; @@ -init_timer(&t); +setup_timer(&t,f,d); -t.data = d; -t.function = f; // Signed-off-by: Julia …