Quentin LAMBERT
Author's posts
Feb 11 2015
pcmcia: Use setup_timer and mod_timer
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of functions setup_timer and mod_timer. This is done using Coccinelle and semantic patch used for this as follows: // @@ expression x,y,z,a,b; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar …
Feb 11 2015
drivers/net: Use setup_timer and mod_timer
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of functions setup_timer and mod_timer. This is done using Coccinelle and semantic patch used for this as follows: // @@ expression x,y,z,a,b; @@ -init_timer (&x); +setup_timer (&x, y, z); +mod_timer (&a, b); -x.function = y; -x.data = z; -x.expires = b; -add_timer(&a); // Signed-off-by: Vaishali Thakkar …
Feb 11 2015
iio: gp2ap020a00f: Use put_unaligned_le32
Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of function put_unaligned_le32. This is done using Coccinelle and semantic patch used is as follows: @@ identifier tmp; expression ptr; expression y,e; type T; @@ – tmp = cpu_to_le32(y); ? tmp = e @@ type T; identifier tmp; @@ – T tmp; …when != tmp Signed-off-by: …
Feb 11 2015
mm/slab_common.c: use kmem_cache_free()
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Here, free memory is allocated using kmem_cache_zalloc. So, use kmem_cache_free instead of kfree. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,E,c; @@ x = \(kmem_cache_alloc\|kmem_cache_zalloc\|kmem_cache_alloc_node\)(c,…) … when != x = E when != &x ?-kfree(x) +kmem_cache_free(c,x) Signed-off-by: Vaishali Thakkar Acked-by: Christoph Lameter Cc: Pekka …
Feb 09 2015
net: Mellanox: Delete unnecessary checks before the function call “vunmap”
Author: Markus Elfring <elfring@users.sourceforge.net> The vunmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Eli Cohen Signed-off-by: David S. Miller — drivers/net/ethernet/mellanox/mlx4/alloc.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/alloc.c | 2 +- 2 files changed, 2 insertions(+), 2 …
Feb 09 2015
PM / OPP / clk: Remove unnecessary OOM message
Author: Quentin Lambert <lambert.quentin@gmail.com> This patch reduces the kernel size by removing error messages that duplicate the normal OOM message. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @@ identifier f,print,l; expression e; constant char[] c; @@ e = \(kzalloc\|kmalloc\|devm_kzalloc\|devm_kmalloc\)(…); if (e == NULL) { } Signed-off-by: Quentin …
Feb 08 2015
ASoC: Intel: fix platform_no_drv_owner.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> sound/soc/intel/cht_bsw_rt5645.c:315:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/intel/cht_bsw_rt5645.c | 1 – 1 file changed, 1 deletion(-) diff –git a/sound/soc/intel/cht_bsw_rt5645.c b/sound/soc/intel/cht_bsw_rt5645.c index b6f8377..bd29617 100644 …
Feb 06 2015
iommu/vt-d: Convert non-returned local variable to boolean when relevant
Author: Quentin Lambert <lambert.quentin@gmail.com> This patch was produced using Coccinelle. A simplified version of the semantic patch is: @r exists@ identifier f; local idexpression u8 x; identifier xname; @@ f(…) { …when any ( x@xname = 1; | x@xname = 0; ) …when any } @bad exists@ identifier r.f; local idexpression u8 r.x expression e1 …
Feb 05 2015
uwb/whci: Delete an unnecessary check before the function call “umc_device_unregister”
Author: Markus Elfring <elfring@users.sourceforge.net> The umc_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman — drivers/uwb/whci.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Feb 05 2015
USB: whci-hcd: Delete an unnecessary check before the function call “usb_put_hcd”
Author: Markus Elfring <elfring@users.sourceforge.net> The usb_put_hcd() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman — drivers/usb/host/whci/hcd.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …