Quentin LAMBERT
Author's posts
Feb 20 2015
staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> To avoid deadlock, do not call blocking functions with spinlocks held. Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile doesn’t have enough free pages but will not sleep and hence deadlock can be avoided. Found by Coccinelle. Signed-off-by: Tapasweni Pathak Signed-off-by: Greg Kroah-Hartman — drivers/staging/emxx_udc/emxx_udc.c | 2 …
Feb 20 2015
dmaengine: jz4740: Remove extra check
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> Remove double check on chan->desc. Found by Coccinelle. Signed-off-by: Tapasweni Pathak Acked-by: Julia Lawall Signed-off-by: Vinod Koul — drivers/dma/dma-jz4740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c index 4527a3e..f6a4c42 100644 — a/drivers/dma/dma-jz4740.c +++ b/drivers/dma/dma-jz4740.c @@ -343,7 +343,7 @@ static void jz4740_dma_chan_irq(struct jz4740_dmaengine_chan *chan) { …
Feb 20 2015
Staging: rtl8723au: Use put_unaligned_le16
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Using byte ordering functions and then memcpy() is risky and prone to hide errors which are hard to track down. So, this patch introduces the use of function put_unaligned_le16 which makes the code clear. Here, use of variable tim_bitmap_le and variable itself is removed. Also, to be compatible with the changes …
Feb 20 2015
Staging: rtl8188eu: Use put_unaligned_le16
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Using byte ordering functions and then memcpy() is risky and prone to hide errors which are hard to track down. So, this patch introduces the use of function put_unaligned_le16 which makes the code clear. Here, use of variable tim_bitmap_le and variable itself is removed. Also, to be compatible with the changes …
Feb 19 2015
staging: comedi: drivers: replace init_timer by setup_timer
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch replaces init_timer and 2 step initialization of function and data by setup_timer to make the code more concise. The issue was discovered using the following coccinelle script: @@ expression ds, e1, e2; @@ -init_timer (&ds); +setup_timer (&ds, e1, e2); … -ds.function = e1; … -ds.data = e2; Acked-by: Julia …
Feb 19 2015
staging: unisys: Remove unnecessary OOM message
Author: Quentin Lambert <lambert.quentin@gmail.com> This patch reduces the kernel size by removing error messages that duplicate the normal OOM message. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @@ identifier f,print,l; expression e; constant char[] c; @@ e = \(kzalloc\|kmalloc\|devm_kzalloc\|devm_kmalloc\)(…); if (e == NULL) { } Signed-off-by: Quentin …
Feb 19 2015
x86/intel/quark: Fix simple_return.cocci warnings
Author: Fengguang Wu <fengguang.wu@intel.com> arch/x86/platform/intel-quark/imr.c:129:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Cc: Andy Shevchenko Cc: Ong, Boon Leong Cc: Bryan O’Donoghue Cc: Darren Hart Cc: kbuild-all@01.org Link: http://lkml.kernel.org/r/20150219081432.GA21996@waimea Signed-off-by: Ingo Molnar — arch/x86/platform/intel-quark/imr.c | 6 +—– 1 …
Feb 19 2015
x86/intel/quark: Fix ptr_ret.cocci warnings
Author: Fengguang Wu <fengguang.wu@intel.com> arch/x86/platform/intel-quark/imr.c:280:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(…)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu Cc: Andy Shevchenko Cc: Ong, Boon Leong Cc: Bryan O’Donoghue Cc: Darren Hart Cc: kbuild-all@01.org Link: http://lkml.kernel.org/r/20150219081432.GA21983@waimea Signed-off-by: Ingo Molnar — arch/x86/platform/intel-quark/imr.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-) …
Feb 19 2015
staging: slicloss: replace init_timer by setup_timer
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch replaces init_timer and the 2 step initialization of function and data by setup_timer to make the code more concise. The issue was discovered using the following coccinelle script: @@ expression ds, e1, e2; @@ -init_timer (&ds); +setup_timer (&ds, e1, e2); … ( -ds.function = e1; … -ds.data = e2; …
Feb 19 2015
staging: rtl8192u: ieee80211: replace init_timer by setup_timer
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch replaces init_timer and the 2 step initialization of function and data by setup_timer to make the code more concise. The issue was discovered using the following coccinelle script: @@ expression ds, e1, e2; @@ -init_timer (&ds); +setup_timer (&ds, e1, e2); … ( -ds.function = e1; … -ds.data = e2; …