Author: Julia Lawall <Julia.Lawall@lip6.fr> The pch_dev_ops structure is never modified. It is only stored in a field that is already declared as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Zhang Rui — drivers/thermal/intel_pch_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/thermal/intel_pch_thermal.c b/drivers/thermal/intel_pch_thermal.c index 50c7da7..00d81af 100644 …
Category: Linux
Oct 11 2015
ALSA: bebob: constify various snd_bebob structures
Author: Julia Lawall <julia.lawall@lip6.fr> The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are initialized. Make them all const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Tested-by: Takashi Sakamoto Reviewed-by: Takashi Sakamoto Signed-off-by: Takashi Iwai — sound/firewire/bebob/bebob.c | 2 +- sound/firewire/bebob/bebob.h | 32 ++++++++++++++++—————- sound/firewire/bebob/bebob_focusrite.c | 26 +++++++++++++————- …
Oct 11 2015
arm: add missing of_node_put
Author: Julia Lawall <julia.lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The of_node_put is duplicated in front of each error return, because the function contains a later error return that is beyond the end of the for_each_child_of_node and thus doesn’t need of_node_put. The semantic patch …
Oct 10 2015
ARM: shmobile: R-Mobile: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != e = child ( return child; …
Oct 10 2015
power_supply: charger-manager: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != e = child ( return child; …
Oct 10 2015
backlight: 88pm860x_bl: Add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != e = child …
Oct 09 2015
clk: tegra: delete unneeded of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@ for_each_child_of_node(root, child) { … when != of_node_get(child) * of_node_put(child); … …
Oct 09 2015
memory: tegra: Delete unneeded of_node_put()
Author: Julia Lawall <julia.lawall@lip6.fr> for_each_child_of_node() performs an of_node_put() on each iteration, so putting an of_node_put() before a continue results in a double put. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@ for_each_child_of_node(root, child) { … when != of_node_get(child) * of_node_put(child); … …
Oct 09 2015
Staging: rdma: Use memdup_user
Author: Ksenija Stanojevic <ksenija.stanojevic@gmail.com> Use memdup_user when user data is immediately copied into the allocated region. Issue found using coccinelle. Signed-off-by: Ksenija Stanojevic Signed-off-by: Greg Kroah-Hartman — drivers/staging/rdma/ipath/ipath_fs.c | 13 +++———- 1 file changed, 3 insertions(+), 10 deletions(-) diff –git a/drivers/staging/rdma/ipath/ipath_fs.c b/drivers/staging/rdma/ipath/ipath_fs.c index 25422a3..796af68 100644 — a/drivers/staging/rdma/ipath/ipath_fs.c +++ b/drivers/staging/rdma/ipath/ipath_fs.c @@ -195,16 +195,9 @@ static …
Oct 08 2015
Staging: rtl8188eu: core: Use ARRAY_SIZE macro
Author: Shraddha Barke <shraddha.6596@gmail.com> ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type. Changes made using Coccinelle- @@ type T; T[] E; @@ – (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/core/rtw_rf.c | 2 +- 2 files …