Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Remove intialisation of a variable that is immediately reassigned. The problem was found using coccinelle semantic patch and further opportunities were identified by hand. The semantic patch used to find this is: // @@ type T; identifier x; constant C; expression e; @@ T x – = C ; x …
Category: Linux
Oct 13 2015
Staging: most: Remove exceptional & on function name
Author: Shraddha Barke <shraddha.6596@gmail.com> In this file, function names are otherwise used as pointers without &. A simplified version of the Coccinelle semantic patch that makes this change is as follows: // @r@ identifier f; @@ f(…) { … } @@ identifier r.f; @@ – &f + f // Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman …
Oct 13 2015
Staging: iio: Remove exceptional & on function name
Author: Shraddha Barke <shraddha.6596@gmail.com> In this file, function names are otherwise used as pointers without &. A simplified version of the Coccinelle semantic patch that makes this change is as follows: // @r@ identifier f; @@ f(…) { … } @@ identifier r.f; @@ – &f + f // Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman …
Oct 13 2015
Staging: comedi: Remove exceptional & on function name
Author: Shraddha Barke <shraddha.6596@gmail.com> n this file, function names are otherwise used as pointers without &. A simplified version of the Coccinelle semantic patch that makes this change is as follows: // @r@ identifier f; @@ f(…) { … } @@ identifier r.f; @@ – &f + f // Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman …
Oct 13 2015
soc: qcom: smd: delete unneeded of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Device node iterators perform an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. A simplified version of the semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator i; @@ i(…, child, …) { … …
Oct 13 2015
video: omapdss: delete unneeded of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Device node iterators perform an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. A simplified version of the semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator i; @@ i(…, child, …) { … …
Oct 11 2015
drm/nouveau/disp,pm: constify nvkm_object_func structures
Author: Julia Lawall <Julia.Lawall@lip6.fr> These nvkm_object_func structures are never modified. All other nvkm_object_func structures are declared as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Ben Skeggs — drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c | 2 +- drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c index 62d3fb6..2be8463 100644 — …
Oct 11 2015
[media] v4l: mt9t001: constify v4l2_subdev_internal_ops structure
Author: Julia Lawall <Julia.Lawall@lip6.fr> This v4l2_subdev_internal_ops structure is never modified. All other v4l2_subdev_internal_ops structures are declared as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab — drivers/media/i2c/mt9t001.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/media/i2c/mt9t001.c b/drivers/media/i2c/mt9t001.c index 702d562..16b8c70 100644 — …
Oct 11 2015
qlcnic: constify qlcnic_mbx_ops structure
Author: Julia Lawall <julia.lawall@lip6.fr> The only instance of a qlcnic_mbx_ops structure is never modified. Thus the declaration of the structure and all references to the structure type can be made const. In the definition of the qlcnic_mailbox structure, the ops field is no longer lined up with the other fields. This was left as is, …
Oct 11 2015
NFC: nxp-nci: constify nxp_nci_phy_ops structure
Author: Julia Lawall <Julia.Lawall@lip6.fr> The only instance of a nxp_nci_phy_ops structure is never modified. Thus the declaration of the structure and all references to the structure type can be made const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Samuel Ortiz — drivers/nfc/nxp-nci/core.c | 3 ++- drivers/nfc/nxp-nci/i2c.c | 2 +- drivers/nfc/nxp-nci/nxp-nci.h | 5 …