Author: Julia Lawall <julia@diku.dk> priv is checked not to be NULL near the beginning of the function and not changed subsequently, making the test redundant. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL …
Category: Linux
Dec 21 2008
PCI hotplug: remove redundant test in cpq hotplug
Author: Julia Lawall <julia@diku.dk> func is checked not to be NULL a few lines before. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL || …) { … when forall return …; } … …
Dec 21 2008
drivers/net/wan: Remove redundant test
Author: Julia Lawall <julia@diku.dk> arg is checked not to be NULL a few lines before. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL || …) { … when forall return …; } … …
Dec 20 2008
fs/9p: change simple_strtol to simple_strtoul
Author: Julia Lawall <julia@diku.dk> Since v9ses->uid is unsigned, it would seem better to use simple_strtoul that simple_strtol. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r2@ long e; position p; @@ e = simple_strtol@p(…) @@ position p != r2.p; type T; T e; @@ e = – …
Dec 19 2008
Staging: go7007: Move a dereference below a NULL test
Author: Julia Lawall <julia@diku.dk> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/). The result has been modified to move the initialization of usb down closer to where it is used. // @@ type …
Dec 19 2008
Staging: agnx: Move a dereference below a NULL test
Author: Julia Lawall <julia@diku.dk> If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ – T i = E->fld; + T i; … when != E when …
Dec 17 2008
drivers/net/hamradio: Move a dereference below a NULL test
Author: Julia Lawall <julia@diku.dk> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ – T i = E->fld; + T i; … when …
Dec 16 2008
[SCSI] lpfc: Move a dereference below a NULL test
Author: Julia Lawall <julia@diku.dk> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ – T i = E->fld; + T i; … when …
Dec 16 2008
drivers/mmc: Move a dereference below a NULL test
Author: Julia Lawall <julia@diku.dk> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ – T i = E->fld; + T i; … when …
Dec 13 2008
[ARM] arch/arm/common/sa1111.c: Correct error handling code
Author: Julia Lawall <julia@diku.dk> If it is reasonable to apply PTR_ERR to the result of calling clk_get, then that result should first be tested with IS_ERR, not with !. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression E,E1; @@ if ( – E == NULL + IS_ERR(E) ) { …