Author: Márton Németh <nm127@freemail.hu> The match_table field of the struct of_device_id is constant in so it is worth to make xps2_of_match also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; … }; …
Category: Linux
Jan 09 2010
mtd: nand: make USB device id constant
Author: Márton Németh <nm127@freemail.hu> The id_table field of the struct usb_device_id is constant in so it is worth to make alauda_table also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; … }; …
Jan 09 2010
mtd: nand: make PCI device id constant
Author: Márton Németh <nm127@freemail.hu> The id_table field of the struct pci_driver is constant in so it is worth to make cafe_nand_tbl also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; … }; …
Jan 04 2010
netfilter: SNMP NAT: correct the size argument to kzalloc
Author: Julia Lawall <julia@diku.dk> obj has type struct snmp_object **, not struct snmp_object *. But indeed it is not even clear why kmalloc is needed. The memory is freed by the end of the function, so the local variable of pointer type should be sufficient. The semantic patch that makes this change is as follows: …
Jan 04 2010
8139too: make PCI device ids constant
Author: Márton Németh <nm127@freemail.hu> The id_table field of the struct pci_driver is constant in so it is worth to make pci_device_id also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; … }; @s@ identifier …
Dec 30 2009
USB: FHCI: Correct the size argument to kzalloc
Author: Julia Lawall <julia@diku.dk> urb_priv->tds has type struct td **, not struct td *, so the elements of the array should have pointer type, not structure type. Convert kzalloc to kcalloc as well. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @disable sizeof_type_expr@ type T; T **x; @@ x = // …
Dec 29 2009
mtd: physmap_of: Correct the size argument to kzalloc
Author: Julia Lawall <julia@diku.dk> mtd_list has type struct mtd_info **, not struct mtd_info *, so the elements of the array should have pointer type, not structure type. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @disable sizeof_type_expr@ type T; T **x; @@ x = // Signed-off-by: Julia Lawall Signed-off-by: David Woodhouse …
Dec 29 2009
drivers/net : Correct the size argument to kzalloc
Author: Julia Lawall <julia@diku.dk> lp->rx_skb has type struct sk_buff **, not struct sk_buff *, so the elements of the array should have pointer type, not structure type. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @disable sizeof_type_expr@ type T; T **x; @@ x = // Signed-off-by: Julia Lawall Signed-off-by: David S. …
Dec 28 2009
V4L/DVB (13954): Correct NULL test
Author: Julia Lawall <julia@diku.dk> Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier f; @@ f(…) { } @@ expression *x; expression y; identifier r.f; statement S; @@ x = f(…); ( if ((x) == NULL) S | if …
Dec 27 2009
drivers/block/drbd: Correct NULL test
Author: Julia Lawall <julia@diku.dk> Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(…); ( if ((x) == NULL) S | if ( – y + x == NULL) S ) // Signed-off-by: …
