Author: Julia Lawall <Julia.Lawall@lip6.fr> Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls to these functions is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – clk_prepare(e); – …
Category: Linux
Aug 26 2012
drivers/staging/iio/adc/spear_adc.c: use clk_prepare_enable and clk_disable_unprepare
Author: Julia Lawall <Julia.Lawall@lip6.fr> Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and clk_enable, and clk_disable and clk_unprepare. They make the code more concise, and ensure that clk_unprepare is called when clk_enable fails. A simplified version of the semantic patch that introduces calls to these functions is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – clk_prepare(e); – …
Aug 26 2012
staging: r8712u: use is_broadcast_ether_addr() to simplify the code
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using is_broadcast_ether_addr() to simplify the code. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Acked-by: Larry Finger Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8712/ethernet.h | 8 ——– drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 +— drivers/staging/rtl8712/rtl871x_ioctl_set.c | 5 +—- 3 files changed, 2 insertions(+), 15 deletions(-) diff –git a/drivers/staging/rtl8712/ethernet.h …
Aug 26 2012
staging: rtl8192e: use is_broadcast_ether_addr() instead of memcmp()
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192e/rtllib_softmac.c | 7 +++—- 1 file changed, 3 insertions(+), 4 deletions(-) diff –git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c …
Aug 26 2012
Staging: rtl8192u: use is_broadcast_ether_addr() instead of memcmp()
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c …
Aug 26 2012
staging: rtl8187se: use is_broadcast_ether_addr() instead of memcmp()
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c | 5 ++— 1 file changed, 2 insertions(+), 3 deletions(-) diff –git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c …
Aug 26 2012
wireless: use is_broadcast_ether_addr() instead of memcmp()
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: John W. Linville — drivers/net/wireless/hostap/hostap_ioctl.c | 15 +++++———- 1 file changed, 5 insertions(+), 10 deletions(-) diff –git a/drivers/net/wireless/hostap/hostap_ioctl.c …
Aug 26 2012
drivers/net/ethernet/tundra/tsi108_eth.c: delete double assignment
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete successive assignments to the same location. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression i; @@ *i = …; i = …; // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller — drivers/net/ethernet/tundra/tsi108_eth.c | 1 – 1 file changed, 1 deletion(-) …
Aug 25 2012
drivers/iio/adc/at91_adc.c: adjust inconsistent IS_ERR and PTR_ERR
Author: Julia Lawall <Julia.Lawall@lip6.fr> Change the call to PTR_ERR to access the value just tested by IS_ERR. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,e1; @@ ( if (IS_ERR(e)) { … PTR_ERR(e) … } | if (IS_ERR(e=e1)) { … PTR_ERR(e) … } | *if (IS_ERR(e)) { … * …
Aug 25 2012
drivers/staging/crystalhd/crystalhd_lnx.c: adjust inconsistent IS_ERR and PTR_ERR
Author: Julia Lawall <Julia.Lawall@lip6.fr> Change the call to PTR_ERR to access the value just tested by IS_ERR. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,e1; @@ ( if (IS_ERR(e)) { … PTR_ERR(e) … } | if (IS_ERR(e=e1)) { … PTR_ERR(e) … } | *if (IS_ERR(e)) { … * …