Author: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> A call to irq_find_matching_host was already made and the result has been stored in mc_msi_domain. mc_msi_domain is again reassigned using the same function call which is redundant. irq_find_matching_host returns/locates a domain for a given fwnode. The domain is identified using device node and bus_token(if several domains have same device node but …
Category: Linux
Feb 28 2016
Staging: rtl8723au: Remove print statements and debug messages
Author: Bhumika Goyal <bhumirks@gmail.com> The memory allocation functions generates a call stack containing all the context information on failure, so print statements and debug messages can be removed on failure of these functions. Also remove unwanted {} around if block after removal of these messages. Done using coccinelle: @@ expression e; @@ e=\(kmalloc\|kmalloc\|kmalloc_array\|alloc_netdev\|kzalloc\| devm_kzalloc\|devm_ioremap\)(…); … …
Feb 28 2016
gpio: timberdale: Switch to devm_ioremap_resource()
Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Replace calls to devm_request_mem_region and devm_ioremap with a direct call to devm_ioremap_resource instead and modify error handling. Move the call to platform_get_resource adjacent to the call to devm_ioremap_resource to make the connection between them more clear. A simplified version of the Coccinelle semantic patch that is used to make this …
Feb 28 2016
staging: rtl8192u: ieee80211: Remove unused variables
Author: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> The pointer *skb2 is declared ‘globally’ inside ifdef NOT_YET. It’s used nowhere in the directory. Another pointer *skb2 is declared ‘locally’, again inside another ifdef NOT_YET in the function ieee80211_rx_frame_mgmt. Hence, skb2 stays unused and has been removed. This was done using Coccinelle: @@ type T; identifier i; constant c; @@ …
Feb 28 2016
staging: wilc1000: Removed unused variables
Author: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Variables pcgroup_encrypt_val,pccipher_group,pcwpa_version, hold different values at different stages of the execution of connect(), however they are not being used anywhere. Hence, the unused variables have been removed. This was done using Coccinelle. @@ type T; identifier i; constant c; @@ -T i; Signed-off-by: Bhaktipriya Shridhar Signed-off-by: Greg Kroah-Hartman — drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | …
Feb 28 2016
Staging: lustre: Remove int typecast of offsetof().
Author: Sandhya Bankar <bankarsandhya512@gmail.com> Remove int typecast of offsetof(). As per below coccinelle rule: @@ type T; expression E; @@ – (int)(offsetof(T,E)) + offsetof(T,E) Signed-off-by: Sandhya Bankar Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h index a176544..a60d72f 100644 — a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h @@ …
Feb 27 2016
staging: lustre: lnet: Use list_for_each_entry_safe
Author: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Doubly linked lists which are iterated using list_empty and list_entry macros have been replaced with list_for_each_entry_safe macro. This makes the iteration simpler and more readable. This patch replaces the while loop containing list_empty and list_entry with list_for_each_entry_safe. This was done with Coccinelle. @@ expression E1; identifier I1, I2; type T; iterator …
Feb 27 2016
staging: wlan-ng: simplify NULL tests
Author: Eva Rachel Retuya <eraretuya@gmail.com> Replace direct comparisons to NULL i.e. ‘x == NULL’ with ‘!x’ for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(…); if ( ( + ! x – == NULL | + ! – NULL == x ) ) Z Signed-off-by: Eva Rachel …
Feb 27 2016
staging: rts5208: simplify NULL tests
Author: Eva Rachel Retuya <eraretuya@gmail.com> Replace direct comparisons to NULL i.e. ‘x == NULL’ with ‘!x’ for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(…); if ( ( + ! x – == NULL | + ! – NULL == x ) ) Z Signed-off-by: Eva Rachel …
Feb 27 2016
staging: ste_rmi4: simplify NULL tests
Author: Eva Rachel Retuya <eraretuya@gmail.com> Replace direct comparisons to NULL i.e. ‘x == NULL’ with ‘!x’ for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(…); if ( ( + ! x – == NULL | + ! – NULL == x ) ) Z Signed-off-by: Eva Rachel …