Category: Linux

[SCSI] pm80xx: remove unneeded NULL check

Author: Dan Carpenter <dan.carpenter@oracle.com> Coccinelle complains about the inconsistent NULL checking on “t”. It turns out the check isn’t needed because we verified that “t” is non-NULL at the start of the function. Signed-off-by: Dan Carpenter Acked-by: Anand Kumar Santhanam Signed-off-by: James Bottomley — drivers/scsi/pm8001/pm8001_hwi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) …

Continue reading

mtd: nand: davinci: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse — drivers/mtd/nand/davinci_nand.c | 13 ++++++++—– 1 file changed, 8 insertions(+), 5 deletions(-)   diff –git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c index c3e15a5..999ad9c 100644 — a/drivers/mtd/nand/davinci_nand.c +++ b/drivers/mtd/nand/davinci_nand.c @@ -623,11 …

Continue reading

drivers: misc: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet Signed-off-by: Greg Kroah-Hartman — drivers/misc/sram.c | 7 ++++— 1 file changed, 4 insertions(+), 3 deletions(-)   diff –git a/drivers/misc/sram.c b/drivers/misc/sram.c index 437192e..4a93886 100644 — a/drivers/misc/sram.c +++ b/drivers/misc/sram.c @@ -50,9 +50,10 @@ static …

Continue reading

spi: bmc2835: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet Signed-off-by: Mark Brown — drivers/spi/spi-bcm2835.c | 7 +++—- 1 file changed, 3 insertions(+), 4 deletions(-)   diff –git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index 89c0b50..a4185e4 100644 — a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -331,10 +331,9 @@ static …

Continue reading

drivers: crypto: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace calls to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet Signed-off-by: Herbert Xu — drivers/crypto/omap-aes.c | 7 +++—- drivers/crypto/omap-sham.c | 7 +++—- 2 files changed, 6 insertions(+), 8 deletions(-)   diff –git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index ee15b0f..305a2aa 100644 — a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -1125,10 …

Continue reading

staging: imx-drm: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet Signed-off-by: Greg Kroah-Hartman — drivers/staging/imx-drm/imx-tve.c | 8 +++—– 1 file changed, 3 insertions(+), 5 deletions(-)   diff –git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c index ac16344..a6efa8f6 100644 — a/drivers/staging/imx-drm/imx-tve.c +++ b/drivers/staging/imx-drm/imx-tve.c @@ -638,11 +638,9 @@ static …

Continue reading

staging: dwc2: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_request_and_ioremap.cocci. Signed-off-by: Laurent Navet Reviewed-by: Matthijs Kooijman Acked-by: Paul Zimmerman Signed-off-by: Greg Kroah-Hartman — drivers/staging/dwc2/pci.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-)   diff –git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c index 8d16530..0fcb9a5 100644 — a/drivers/staging/dwc2/pci.c +++ …

Continue reading

drivers/video/mmp/core.c: fix use-after-free bug

Author: Andrei Epure <epure.andrei@gmail.com> Found with coccinelle. Signed-off-by: Andrei Epure Cc: Florian Tobias Schandinat Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds — drivers/video/mmp/core.c | 2 — 1 file changed, 2 deletions(-)   diff –git a/drivers/video/mmp/core.c b/drivers/video/mmp/core.c index 9ed8341..84de263 100644 — a/drivers/video/mmp/core.c +++ b/drivers/video/mmp/core.c @@ -252,7 +252,5 @@ void mmp_unregister_path(struct mmp_path *path)   kfree(path); mutex_unlock(&disp_lock); – – …

Continue reading

net: ethernet: stmicro: stmmac: use devm_ioremap_resource()

Author: Silviu-Mihai Popescu <silviupopescu1990@gmail.com> Convert use of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. This was found with coccinelle. Signed-off-by: Silviu-Mihai Popescu Signed-off-by: David S. Miller — drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 8 +++—– …

Continue reading

KVM: VMX: Add missing braces to avoid redundant error check

Author: Jan Kiszka <jan.kiszka@siemens.com> The code was already properly aligned, now also add the braces to avoid that err is checked even if alloc_apic_access_page didn’t run and change it. Found via Coccinelle by Fengguang Wu. Signed-off-by: Jan Kiszka Signed-off-by: Gleb Natapov — arch/x86/kvm/vmx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)   diff …

Continue reading