Category: Linux

Input: twl4030_keypad – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_threaded_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_threaded_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

Input: pxa27x_keypad – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

Input: ep93xx_keypad – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

drm/exynos: exynos_hdmi: Pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_threaded_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_threaded_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

crypto: hifn_795x – Pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

tty: nwpserial: Pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

spi: topcliff-pch: Pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

drivers: char: ipmi: Replaced kmalloc and strcpy with kstrdup

Author: Alexandru Gheorghiu <gheorghiuandru@gmail.com> Replaced calls to kmalloc followed by strcpy with a sincle call to kstrdup. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu Signed-off-by: Corey Minyard Signed-off-by: Linus Torvalds — drivers/char/ipmi/ipmi_msghandler.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff –git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 4d439d2..4445fa1 100644 — a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ …

Continue reading

staging: lustre: fix return type of lo_release.

Author: Cyril Roelandt <tipecaml@gmail.com> The return type of block_device_operations.release() changed to void in commit db2a144b. Found with the following Coccinelle patch: @has_release_func@ identifier i; identifier release_func; @@ struct block_device_operations i = { .release = release_func }; @depends on has_release_func@ identifier has_release_func.release_func; @@ – int + void release_func(…) { … – return …; } Signed-off-by: Cyril …

Continue reading

drivers: pinctrl: vt8500: use devm_ioremap_resource()

Author: Laurent Navet <laurent.navet@gmail.com> Replace a call to deprecated devm_request_and_ioremap by devm_ioremap_resource. Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet Acked-by: Tony Prisk Signed-off-by: Linus Walleij — drivers/pinctrl/vt8500/pinctrl-wmt.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-)   diff –git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c index 70d986e..fb30edf3 100644 — a/drivers/pinctrl/vt8500/pinctrl-wmt.c +++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c @@ -569,10 …

Continue reading