Category: Linux

staging: lustre: use ERR_CAST() function

Author: Laurent Navet <laurent.navet@gmail.com> use ERR_CAST() function instead of ERR_PTR() and PTR_ERR() found using coccinelle and err_cast.cocci Signed-off-by: Laurent Navet Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/llite/llite_nfs.c | 2 +- drivers/staging/lustre/lustre/llite/rw.c | 2 +- drivers/staging/lustre/lustre/obdclass/local_storage.c | 4 ++– 3 files changed, 4 insertions(+), 4 deletions(-)   diff –git a/drivers/staging/lustre/lustre/llite/llite_nfs.c b/drivers/staging/lustre/lustre/llite/llite_nfs.c index b830004..32362ec 100644 — a/drivers/staging/lustre/lustre/llite/llite_nfs.c +++ b/drivers/staging/lustre/lustre/llite/llite_nfs.c …

Continue reading

drivers/parport/share.c: use kzalloc

Author: Alexandru Gheorghiu <gheorghiuandru@gmail.com> Replaced calls to kmalloc and memset with kzalloc. Patch found using coccinelle. Signed-off-by: Alexandru Gheorghiu Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds — drivers/parport/share.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff –git a/drivers/parport/share.c b/drivers/parport/share.c index a848e02..6a83ee1 100644 — a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -282,14 +282,13 @@ struct parport …

Continue reading

bnx2x: Remove sparse and coccinelle warnings

Author: Yuval Mintz <yuvalmin@broadcom.com> This patch solves several sparse issues as well as an unneeded semicolon found via coccinelle. Signed-off-by: Yuval Mintz Signed-off-by: Dmitry Kravkov Signed-off-by: Ariel Elior Signed-off-by: Eilon Greenstein Signed-off-by: David S. Miller — drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 9 ++++++— drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 8 +++++— drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- 3 files changed, 12 insertions(+), 7 deletions(-) …

Continue reading

HID: wiimote: fix coccinelle warnings

Author: Jiri Kosina <jkosina@suse.cz> drivers/hid/hid-wiimote-modules.c:569:2-3: Unneeded semicolon Generated by: coccinelle/misc/semicolon.cocci Reported-by: Fengguang Wu Signed-off-by: Jiri Kosina — drivers/hid/hid-wiimote-modules.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-modules.c index 8229d0a..68f67f0 100644 — a/drivers/hid/hid-wiimote-modules.c +++ b/drivers/hid/hid-wiimote-modules.c @@ -566,7 +566,7 @@ static void wiimod_ir_in_ir(struct wiimote_data *wdata, const __u8 *ir, break; default: return; …

Continue reading

crypto: crct10dif – Use PTR_RET

Author: Herbert Xu <herbert@gondor.apana.org.au> lib/crc-t10dif.c:42:1-3: WARNING: PTR_RET can be used Use PTR_RET rather than if(IS_ERR(…)) + PTR_ERR Generated by: coccinelle/api/ptr_ret.cocci Reported-by: Fengguang Wu Signed-off-by: Herbert Xu — lib/crc-t10dif.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-)   diff –git a/lib/crc-t10dif.c b/lib/crc-t10dif.c index 0cb6463..fe3428c 100644 — a/lib/crc-t10dif.c +++ b/lib/crc-t10dif.c @@ -39,9 +39,7 @@ EXPORT_SYMBOL(crc_t10dif); …

Continue reading

drivers/rtc/rtc-pl031.c: pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

Input: navpoint – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

Input: pmic8xxx-pwrkey – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

Input: ixp4xx-beeper – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading

Input: w90p910_keypad – pass correct pointer to free_irq()

Author: Lars-Peter Clausen <lars@metafoo.de> free_irq() expects the same pointer that was passed to request_irq(), otherwise the IRQ is not freed. The issue was found using the following coccinelle script: @r1@ type T; T devid; @@ request_irq(…, devid) @r2@ type r1.T; T devid; position p; @@ free_irq@p(…, devid) @@ position p != r2.p; @@ *free_irq@p(…) Signed-off-by: …

Continue reading