Category: Linux

arch/arm/mach-ux500/cpu-db8500.c: Avoid using ARRAY_AND_SIZE(e) as a function argument

Author: Julia Lawall <Julia.Lawall@lip6.fr> Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the arity of the called function. The semantic match that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,f; @@ f(…, – ARRAY_AND_SIZE(e) + e,ARRAY_SIZE(e) ,…) // Signed-off-by: Julia Lawall Signed-off-by: Linus Walleij — arch/arm/mach-ux500/cpu-db8500.c | 3 ++- 1 file …

Continue reading

sound/soc/pxa/mioa701_wm9713.c: Avoid using ARRAY_AND_SIZE(e) as a function argument

Author: Julia Lawall <Julia.Lawall@lip6.fr> Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the arity of the called function. The semantic match that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,f; @@ f(…, – ARRAY_AND_SIZE(e) + e,ARRAY_SIZE(e) ,…) // Signed-off-by: Julia Lawall Signed-off-by: Mark Brown — sound/soc/pxa/mioa701_wm9713.c | 5 +++– 1 file …

Continue reading

TTY: synclink: replace bitmasks add operation with OR operation.

Author: Alexandru Juncu <alexj@rosedu.org> Found with coccinelle, manually fixed and verified. Signed-off-by: Alexandru Juncu Signed-off-by: Greg Kroah-Hartman — drivers/tty/synclink.c | 130 ++++++++++++++++++++++++————————- 1 file changed, 65 insertions(+), 65 deletions(-)   diff –git a/drivers/tty/synclink.c b/drivers/tty/synclink.c index 8eaf1ab..e1ce141 100644 — a/drivers/tty/synclink.c +++ b/drivers/tty/synclink.c @@ -577,22 +577,22 @@ struct mgsl_struct {   #define SICR_RXC_ACTIVE BIT15 #define SICR_RXC_INACTIVE BIT14 …

Continue reading

drm/i915: Acquire dpio_lock for VLV sideband programming in DP/HDMI

Author: Chris Wilson <chris@chris-wilson.co.uk> Otherwise we get flooded by the kernel warning us that we are doing long sequences of IO without serialisation. For example, WARNING: CPU: 0 PID: 11136 at drivers/gpu/drm/i915/intel_sideband.c:40 vlv_sideband_rw+0x48/0x1ef() Modules linked in: CPU: 0 PID: 11136 Comm: kworker/u2:0 Tainted: G W 3.11.0-rc2+ #4 Call Trace: [] ? warn_slowpath_common+0x63/0x78 [] ? vlv_sideband_rw+0x48/0x1ef …

Continue reading

MIPS:Netlogic: Remove redundant value in operation.

Author: Alexandru Juncu <alexj@rosedu.org> Removed parameters checked twice in logical OR operation. Suggested by coccinelle and manually verified. Signed-off-by: Alexandru Juncu Cc: jchandra@broadcom.com Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/5627/ Signed-off-by: Ralf Baechle — arch/mips/netlogic/xlp/usb-init.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff –git a/arch/mips/netlogic/xlp/usb-init.c b/arch/mips/netlogic/xlp/usb-init.c index ef3897e..d5378ef 100644 — a/arch/mips/netlogic/xlp/usb-init.c +++ …

Continue reading

pcmcia: synclink_cs: replace sum of bitmasks with OR operation.

Author: Alexandru Juncu <alexj@rosedu.org> Suggested by coccinelle and manually verified. Signed-off-by: Alexandru Juncu Signed-off-by: Greg Kroah-Hartman — drivers/char/pcmcia/synclink_cs.c | 26 +++++++++++++————- 1 file changed, 13 insertions(+), 13 deletions(-)   diff –git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index 5c5cc00..d39cca6 100644 — a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -1182,14 +1182,14 @@ static irqreturn_t mgslpc_isr(int dummy, void *dev_id) } count++;   – if …

Continue reading

mISDN: replace sum of bitmasks with OR operation.

Author: Alexandru Juncu <alexj@rosedu.org> Suggested by coccinelle and manually verified. Signed-off-by: Alexandru Juncu Signed-off-by: David S. Miller — drivers/isdn/hardware/mISDN/hfcpci.c | 12 ++++++—— 1 file changed, 6 insertions(+), 6 deletions(-)   diff –git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c index a7e4939..7f910c7 100644 — a/drivers/isdn/hardware/mISDN/hfcpci.c +++ b/drivers/isdn/hardware/mISDN/hfcpci.c @@ -1307,11 +1307,11 @@ mode_hfcpci(struct bchannel *bch, int bc, int protocol) } if (fifo2 …

Continue reading

ALSA: hdspm – remove unneeded semicolon

Author: Fengguang Wu <fengguang.wu@intel.com> sound/pci/rme9652/hdspm.c:1110:2-3: Unneeded semicolon Generated by: coccinelle/misc/semicolon.cocci Reported-by: Fengguang Wu Signed-off-by: Takashi Iwai — sound/pci/rme9652/hdspm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c index a3a71ac..ec6335e 100644 — a/sound/pci/rme9652/hdspm.c +++ b/sound/pci/rme9652/hdspm.c @@ -1250,7 +1250,7 @@ static int hdspm_rate_multiplier(struct hdspm *hdspm, int rate) else if (hdspm->control_register & …

Continue reading

Staging: silicom: Remove useless unneeded semicolons

Author: Vladimir <gg.kaspersky@gmail.com> Found using coccinelle tool. Signed-off-by: Vladimir Cernov Signed-off-by: Greg Kroah-Hartman — drivers/staging/silicom/bpctl_mod.c | 18 +++++++++——— 1 file changed, 9 insertions(+), 9 deletions(-)   diff –git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c index 32bc530..495272d 100644 — a/drivers/staging/silicom/bpctl_mod.c +++ b/drivers/staging/silicom/bpctl_mod.c @@ -1809,7 +1809,7 @@ int cmnd_off(struct bpctl_dev *pbpctl_dev) else data_pulse(pbpctl_dev, CMND_OFF); ret = 0; – }; + } …

Continue reading

bnx2x: fix tunneling CSUM calculation

Author: Dmitry Kravkov <dmitry@broadcom.com> Since commit c957d09ffda417f6c8e3d1f10e2b05228607d6d7 “bnx2x: Remove sparse and coccinelle warnings” driver provided wrong partial csum for HW in tunneing scenarios. Reported-by: Eric Dumazet CC: Alexander Duyck CC: Pravin Shelar CC: Cong Wang Signed-off-by: Dmitry Kravkov Tested-by: Eric Dumazet Signed-off-by: David S. Miller — drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 6 +++— 1 file changed, 3 insertions(+), …

Continue reading