Author: Valentina Manea <valentina.manea.m@gmail.com> This patch fixes coccinelle errors regarding comparisons used in bool tests. Signed-off-by: Valentina Manea Reviewed-by: Rusty Russell Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 6 +++— 2 files changed, 4 insertions(+), 4 deletions(-) diff –git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c index 58a1661..b45461f 100644 — a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c @@ -193,7 +193,7 …
Category: Linux
Oct 25 2013
staging: rtl8192e: do not use comparisons on bool tests
Author: Valentina Manea <valentina.manea.m@gmail.com> This patch fixes coccinelle errors regarding comparisons used in bool tests. Signed-off-by: Valentina Manea Reviewed-by: Lisa Nguyen Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 6 +++— drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++—- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 ++++—– drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 14 ++++++——– drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 11 +++++—— drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++– drivers/staging/rtl8192e/rtllib_rx.c | …
Oct 25 2013
staging: rtl8192u: use memdup_user to simplify code
Author: Teodora Baluta <teobaluta@gmail.com> Use memdup_user rather than duplicating its implementation. Fix the following coccinelle warnings: drivers/staging/rtl8192u/r8192U_core.c:3792:7-14: WARNING opportunity for memdup_user drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:3153:9-16: WARNING opportunity for memdup_user Signed-off-by: Teodora Baluta Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 11 +++——– drivers/staging/rtl8192u/r8192U_core.c | 11 +++——– 2 files changed, 6 insertions(+), 16 deletions(-) diff –git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c index 5fd6969..662c7e4 …
Oct 23 2013
staging: lustre: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
Author: Valentina Manea <valentina.manea.m@gmail.com> This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Valentina Manea Reviewed-by: Rusty Russell Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/fid/fid_request.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-) diff –git a/drivers/staging/lustre/lustre/fid/fid_request.c b/drivers/staging/lustre/lustre/fid/fid_request.c index 66007b5..79fc2fe 100644 — a/drivers/staging/lustre/lustre/fid/fid_request.c +++ b/drivers/staging/lustre/lustre/fid/fid_request.c @@ -548,9 +548,7 @@ …
Oct 23 2013
staging: drm/imx: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
Author: Valentina Manea <valentina.manea.m@gmail.com> This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Valentina Manea Reviewed-by: Rusty Russell Signed-off-by: Greg Kroah-Hartman — drivers/staging/imx-drm/imx-ldb.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-) diff –git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index 926f493..654bf03 100644 — a/drivers/staging/imx-drm/imx-ldb.c +++ b/drivers/staging/imx-drm/imx-ldb.c @@ -359,10 +359,8 @@ …
Oct 23 2013
staging: gdm724x: kzalloc should be used instead of kmalloc/memset
Author: Teodora Baluta <teobaluta@gmail.com> This patch fixes the following coccinelle warnings in driver gdm724x: drivers/staging/gdm724x/gdm_usb.c:127:9-16: WARNING: kzalloc should be used for t_sdu, instead of kmalloc/memset drivers/staging/gdm724x/gdm_usb.c:91:5-12: WARNING: kzalloc should be used for t, instead of kmalloc/memset Signed-off-by: Teodora Baluta Reviewed-by: Peter P Waskiewicz Jr Signed-off-by: Greg Kroah-Hartman — drivers/staging/gdm724x/gdm_usb.c | 6 ++—- 1 file changed, …
Oct 18 2013
ALSA: emu10k1: code refactoring
Author: Geyslan G. Bem <geyslan@gmail.com> Partially restructures _snd_emu10k1_audigy_init_efx() and _snd_emu10k1_init_efx() functions. Be noted that the cast is demanded to use ‘__user’. So, in these cases, avoid patches based on the coccinelle ‘drop_kmalloc_cast’ semantic patch. Signed-off-by: Geyslan G. Bem Signed-off-by: Takashi Iwai — sound/pci/emu10k1/emufx.c | 76 ++++++++++++++++++++++++++++——————- 1 file changed, 45 insertions(+), 31 deletions(-) diff …
Oct 14 2013
btrfs: simplify kmalloc+copy_from_user to memdup_user
Author: Geyslan G. Bem <geyslan@gmail.com> Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives The semantic patch that makes this report is available in scripts/coccinelle/api/memdup_user.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Geyslan G. Bem Signed-off-by: Josef Bacik Signed-off-by: Chris Mason — fs/btrfs/ioctl.c | …
Oct 11 2013
wcn36xx: fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 106 /c/kernel-tests/src/i386/drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 148 This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. Generated by: coccinelle/api/simple_open.cocci CC: Eugene Krasnikov CC: John W. Linville Signed-off-by: …
Oct 10 2013
rcu: Fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> This commit fixes the following coccinelle warning: kernel/rcu/tree.c:712:9-10: WARNING: return of 0/1 in function ‘rcu_lockdep_current_cpu_online’ with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: coccinelle/misc/boolreturn.cocci Signed-off-by: Fengguang Wu Signed-off-by: Paul E. McKenney — kernel/rcu/tree.c | 2 +- 1 file changed, 1 insertion(+), …