Author: Fengguang Wu <fengguang.wu@intel.com> net/netfilter/ipset/ip_set_hash_netnet.c:115:8-9: WARNING: return of 0/1 in function ‘hash_netnet4_data_list’ with return type bool /c/kernel-tests/src/cocci/net/netfilter/ipset/ip_set_hash_netnet.c:338:8-9: WARNING: return of 0/1 in function ‘hash_netnet6_data_list’ with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: coccinelle/misc/boolreturn.cocci Signed-off-by: Fengguang Wu Signed-off-by: Jozsef Kadlecsik — net/netfilter/ipset/ip_set_hash_netnet.c | 8 ++++—- 1 …
Category: Linux
Dec 22 2013
iwlwifi: mvm: fix harmless smatch / coccinelle warnings
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Don’t check if mvm->fw->cs is NULL since it can’t be. cs is an array member of iwl_fw, it can’t be NULL. Use memset(ptr, 0, sizeof(*ptr)); instead of memset(ptr, 0, sizeof(struct ptr_type)); Signed-off-by: Emmanuel Grumbach — drivers/net/wireless/iwlwifi/mvm/mac80211.c | 2 +- drivers/net/wireless/iwlwifi/mvm/rs.c | 4 ++– 2 files changed, 3 insertions(+), 3 deletions(-) …
Dec 20 2013
[media] fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/staging/media/bcm2048/radio-bcm2048.c:2255:3-4: Unneeded semicolon Removes unneeded semicolon. Generated by: coccinelle/misc/semicolon.cocci CC: Hans Verkuil CC: Mauro Carvalho Chehab Signed-off-by: Fengguang Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab — drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index 9344dae..b2cd3a8 100644 — a/drivers/staging/media/bcm2048/radio-bcm2048.c +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c @@ …
Dec 20 2013
[media] fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/staging/media/bcm2048/radio-bcm2048.c:2632:1-7: Replace memcpy with struct assignment /c/kernel-tests/src/cocci/drivers/staging/media/bcm2048/radio-bcm2048.c:744:1-7: Replace memcpy with struct assignment /c/kernel-tests/src/cocci/drivers/staging/media/bcm2048/radio-bcm2048.c:2360:3-9: Replace memcpy with struct assignment Generated by: coccinelle/misc/memcpy-assign.cocci CC: Hans Verkuil CC: Mauro Carvalho Chehab Signed-off-by: Fengguang Wu Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab — drivers/staging/media/bcm2048/radio-bcm2048.c | 8 +++—– 1 file changed, 3 insertions(+), 5 deletions(-) …
Dec 18 2013
i40e: use assignment instead of memcpy
Author: Mitch Williams <mitch.a.williams@intel.com> These instances were found by coccinelle/spatch, and can use struct assignment instead of memcpy. Change-ID: Idc23c3599241bf8a658bda18c80417af3fbfee66 Signed-off-by: Mitch Williams Signed-off-by: Jesse Brandeburg Tested-by: Sibai Li Tested-by: Kavindya Deegala Signed-off-by: Jeff Kirsher — drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 3 +– drivers/net/ethernet/intel/i40e/i40e_hmc.c | 8 +++—– 3 files changed, 5 insertions(+), 8 deletions(-) …
Dec 16 2013
ASoC: axi-spdif: Use devm_ioremap_resource() instead of devm_request_and_ioremap()
Author: Fengguang Wu <fengguang.wu@intel.com> devm_request_and_ioremap() has been deprecated in favour of devm_ioremap_resource(). Fixes the following coccinelle warning: sound/soc/adi/axi-spdif.c:194:8-32: ERROR: deprecated devm_request_and_ioremap() API used on line 194 Generated by: coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Fengguang Wu Signed-off-by: Lars-Peter Clausen Signed-off-by: Mark Brown — sound/soc/adi/axi-spdif.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/sound/soc/adi/axi-spdif.c b/sound/soc/adi/axi-spdif.c …
Dec 16 2013
ASoC: axi-spdif: Use devm_ioremap_resource() instead of devm_request_and_ioremap()
Author: Fengguang Wu <fengguang.wu@intel.com> devm_request_and_ioremap() has been deprecated in favour of devm_ioremap_resource(). Fixes the following coccinelle warning: sound/soc/adi/axi-i2s.c:195:8-32: ERROR: deprecated devm_request_and_ioremap() API used on line 195 Generated by: coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Fengguang Wu Signed-off-by: Lars-Peter Clausen Signed-off-by: Mark Brown — sound/soc/adi/axi-i2s.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c …
Dec 11 2013
drm: use memdup_user() as a cleanup
Author: Dan Carpenter <dan.carpenter@oracle.com> drivers/gpu/drm/r128/r128_state.c:1014:10-17: WARNING opportunity for memdup_user /c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:1029:9-16: WARNING opportunity for memdup_user /c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:904:10-17: WARNING opportunity for memdup_user /c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:914:9-16: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: coccinelle/api/memdup_user.cocci CC: Daniel Vetter Signed-off-by: Dan Carpenter Signed-off-by: Daniel Vetter Signed-off-by: Dave …
Dec 09 2013
crytpo: ccp – fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/crypto/ccp/ccp-crypto-aes.c:344:1-7: Replace memcpy with struct assignment drivers/crypto/ccp/ccp-crypto-sha.c:398:1-7: Replace memcpy with struct assignment drivers/crypto/ccp/ccp-dev.c:578:2-3: Unneeded semicolon /c/kernel-tests/src/cocci/drivers/crypto/ccp/ccp-dev.c:565:2-3: Unneeded semicolon Generated by: coccinelle/misc/memcpy-assign.cocci CC: Tom Lendacky Signed-off-by: Fengguang Wu Signed-off-by: Herbert Xu — drivers/crypto/ccp/ccp-crypto-aes.c | 2 +- drivers/crypto/ccp/ccp-crypto-sha.c | 2 +- drivers/crypto/ccp/ccp-dev.c | 4 ++– 3 files changed, 4 insertions(+), 4 deletions(-) …
Dec 05 2013
USB: fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/usb/host/ehci-mv.c:181:26-27: WARNING comparing pointer to 0, suggest !E /c/kernel-tests/src/cocci/drivers/usb/host/ehci-mv.c:181:26-27: WARNING comparing pointer to 0 Compare pointer-typed values to NULL rather than 0 Semantic patch information: This makes an effort to choose between !x and x == NULL. !x is used if it has previously been used with the function used to …