Author: Julia Lawall <Julia.Lawall@lip6.fr> Use c99 initializers for structures. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @decl@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; …}; @bad@ identifier decl.i1,i2; expression e; initializer list[decl.n] is; @@ struct i1 i2 = { …
Category: Linux
Aug 22 2014
sched/fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 22 2014
kernel: trace_syscalls: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The uses of “rcu_assign_pointer()” are NULLing out the pointers. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 22 2014
perf/callchain: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 22 2014
perf/core: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 22 2014
mac80211: scan: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 22 2014
br_multicast: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> The use of “rcu_assign_pointer()” is NULLing out the pointer. According to RCU_INIT_POINTER()’s block comment: “1. This use of RCU_INIT_POINTER() is NULLing out the pointer” it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ – rcu_assign_pointer + …
Aug 21 2014
mfd: menelaus: Fix error return code
Author: Julia Lawall <julia.lawall@lip6.fr> Convert a zero return value on error to a negative one, as returned elsewhere in the function. Additionally, converted 1
Aug 20 2014
af_decnet: Use time_after_eq
Author: Himangi Saraogi <himangi774@gmail.com> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the Coccinelle semantic patch making this change is as follows: @change@ expression E1,E2,E3; @@ – jiffies – E1 >= (E2*E3) + time_after_eq(jiffies, E1+E2*E3) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Signed-off-by: David …
Aug 20 2014
decnet: Use time_after_eq
Author: Himangi Saraogi <himangi774@gmail.com> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the Coccinelle semantic patch making this change is as follows: @change@ expression E1,E2; @@ – (jiffies – E1) >= E2 + time_after_eq(jiffies, E1+E2) Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Signed-off-by: David …
