Category: Linux

Staging: rtl8192u: Remove unnecessary semicolon.

Author: Sandhya Bankar <bankarsandhya512@gmail.com> Remove unnecessary semicolon.This issue is found by coccinelle script. Signed-off-by: Sandhya Bankar Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c index 5c3bb3b..d733fb2 100644 — a/drivers/staging/rtl8192u/r8190_rtl8256.c +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c @@ -194,7 +194,7 @@ void phy_RF8256_Config_ParaFile(struct net_device *dev) break; }   – …

Continue reading

Staging: i4l: pcbit: drv: Remove unnecessary semicolon.

Author: Sandhya Bankar <bankarsandhya512@gmail.com> Remove unnecessary semicolon.This issue is detected by coccinelle script. Signed-off-by: Sandhya Bankar Signed-off-by: Greg Kroah-Hartman — drivers/staging/i4l/pcbit/drv.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-)   diff –git a/drivers/staging/i4l/pcbit/drv.c b/drivers/staging/i4l/pcbit/drv.c index c79ee84..c5270e2 100644 — a/drivers/staging/i4l/pcbit/drv.c +++ b/drivers/staging/i4l/pcbit/drv.c @@ -284,7 +284,7 @@ static int pcbit_command(isdn_ctrl *ctl) default: printk(KERN_DEBUG "pcbit_command: unknown …

Continue reading

drm/i915: Use shorter route to dev_private where possible

Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Where we have a request we can use req->i915 directly instead of going through the engine and device. Coccinelle script: @@ function f; identifier r; @@ f(…, struct drm_i915_gem_request *r, …) { … – engine->dev->dev_private + r->i915 … } @@ struct drm_i915_gem_request *req; @@ ( req-> – engine->dev->dev_private + i915 ) …

Continue reading

drm/i915: More intel_engine_cs renaming

Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Some trivial ones, first pass done with Coccinelle: @@ @@ ( – I915_NUM_RINGS + I915_NUM_ENGINES | – intel_ring_flag + intel_engine_flag | – for_each_ring + for_each_engine | – i915_gem_request_get_ring + i915_gem_request_get_engine | – intel_ring_idle + intel_engine_idle | – i915_gem_reset_ring_status + i915_gem_reset_engine_status | – i915_gem_reset_ring_cleanup + i915_gem_reset_engine_cleanup | – init_ring_lists + init_engine_lists ) …

Continue reading

drm/i915: Rename local struct intel_engine_cs variables

Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Done by the Coccinelle script below plus a manual intervention to GEN8_RING_SEMAPHORE_INIT. @@ expression E; @@ – struct intel_engine_cs *ring = E; + struct intel_engine_cs *engine = E; @@ @@ – struct intel_engine_cs *ring; + struct intel_engine_cs *engine; Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson — drivers/gpu/drm/i915/i915_debugfs.c | 203 ++++—- drivers/gpu/drm/i915/i915_gem.c | …

Continue reading

staging: iio: isl29028: use regmap to retrieve struct device

Author: Alison Schofield <amsfield22@gmail.com> Driver includes struct regmap and struct device in its global data. Remove the struct device and use regmap API to retrieve device info. Simplified version of Coccinelle semantic patch used: @ a @ identifier drvdata, r; position p; @@ struct drvdata@p { … struct regmap *r; … }; @ b @ …

Continue reading

staging: slicoss: Add error check for pci_map_single

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Currently, DMA mapping failure is not detected, causing the hardware to attempt a DMA from an invalid address. This patch adds the corresponding error check for pci_map_single i.e. pci_dma_mapping_error. Problem found using the following Coccinelle semantic patch: // @@ expression e1; identifier x; @@ x= ( *dma_map_single(…) | *dma_map_page(…) ) …

Continue reading

staging: mt29f_spinand: Replacing pr_info with dev_info after the call to devm_kzalloc

Author: G Pooja Shamili <poojashamili@gmail.com> The function devm_kzalloc has a first argument of type struct device *. This is the type of argument required by printing functions such as dev_info, dev_err, etc. Thus, functions like pr_info should not normally be used after a call to devm_kzalloc. Thus, all pr_info occurances are replaced with dev_info function …

Continue reading

staging: lustre: lnet: o2iblnd: Use list_for_each_entry_safe

Author: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Doubly linked lists which are iterated using list_empty and list_entry macros have been replaced with list_for_each_entry_safe macro. This makes the iteration simpler and more readable. This patch replaces the while loop containing list_empty and list_entry with list_for_each_entry_safe. This was done with Coccinelle. @@ expression E1; identifier I1, I2; type T; iterator …

Continue reading

staging: lustre: lnet: socklnd: Use list_for_each_entry_safe

Author: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Doubly linked lists which are iterated using list_empty and list_entry macros have been replaced with list_for_each_entry_safe macro. This makes the iteration simpler and more readable. This patch replaces the while loop containing list_empty and list_entry with list_for_each_entry_safe. This was done with Coccinelle. @@ expression E1; identifier I1, I2; type T; iterator …

Continue reading