Author: Markus Elfring <elfring@users.sourceforge.net> The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Vinod Koul — drivers/dma/dmaengine.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Category: Linux
Dec 01 2014
thermal: int3403: Delete a check before thermal_zone_device_unregister()
Author: Markus Elfring <elfring@users.sourceforge.net> The thermal_zone_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Zhang Rui — drivers/thermal/int340x_thermal/int3403_thermal.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Dec 01 2014
[media] V4L2: Deletion of an unnecessary check before the function call “vb2_put_vma”
Author: Markus Elfring <elfring@users.sourceforge.net> The vb2_put_vma() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Marek Szyprowski Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab — drivers/media/v4l2-core/videobuf2-vmalloc.c | 3 +– 1 file …
Nov 30 2014
[media] ddbridge: remove unneeded check before dvb_unregister_device()
Author: Markus Elfring <elfring@users.sourceforge.net> The dvb_unregister_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Mauro Carvalho Chehab — drivers/media/pci/ddbridge/ddbridge-core.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) …
Nov 30 2014
xfs: fix simple_return.cocci warning in xfs_bmse_shift_one
Author: kbuild test robot <fengguang.wu@intel.com> fs/xfs/libxfs/xfs_bmap.c:5591:1-6: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Brian Foster Signed-off-by: Fengguang Wu — fs/xfs/libxfs/xfs_bmap.c | 6 +—– 1 file changed, 1 insertion(+), 5 deletions(-) diff –git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 79c9819..20d2e96 100644 — a/fs/xfs/libxfs/xfs_bmap.c …
Nov 30 2014
xfs: fix simple_return.cocci warning in xfs_file_readdir
Author: kbuild test robot <fengguang.wu@intel.com> fs/xfs/xfs_file.c:919:1-6: WARNING: end returns can be simpified and declaration on line 902 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner — fs/xfs/xfs_file.c | 6 +—– 1 file changed, 1 insertion(+), 5 …
Nov 30 2014
libxfs: fix simple_return.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> fs/xfs/libxfs/xfs_ialloc.c:1141:1-6: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner — fs/xfs/libxfs/xfs_ialloc.c | 6 +—– 1 file changed, 1 insertion(+), 5 deletions(-) diff –git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c index 23dcb72..705a753 …
Nov 30 2014
xfs: remove unnecessary null checks
Author: Markus Elfring <elfring@users.sourceforge.net> The functions xfs_blkdev_put() and xfs_qm_dqrele() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner — fs/xfs/xfs_qm.c | 12 +++++——- fs/xfs/xfs_super.c | 3 +– …
Nov 30 2014
usbip: remove unneeded structure
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x,i; @@ { … when any -struct i x; } // Signed-off-by: Julia Lawall Acked-by: Valentina Manea Signed-off-by: Greg Kroah-Hartman — tools/usb/usbip/src/usbipd.c | 2 …
Nov 30 2014
staging: unisys: remove unneeded structure
Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x,i; @@ { … when any -struct i x; } // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/unisys/visorchipset/visorchipset_main.c | 3 — 1 file …