Category: Linux

ASoC: Intel: Delete an unnecessary check before the function call “sst_dma_free”

Author: Markus Elfring <elfring@users.sourceforge.net> The sst_dma_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Mark Brown — sound/soc/intel/sst-dsp.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Continue reading

ALSA: emux: Delete an unnecessary check before the function call “snd_sf_free”

Author: Markus Elfring <elfring@users.sourceforge.net> The snd_sf_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/synth/emux/emux.c | 6 +—– 1 file changed, 1 insertion(+), 5 deletions(-)   diff …

Continue reading

ALSA: oxygen: Delete an unnecessary check before the function call “snd_pcm_suspend”

Author: Markus Elfring <elfring@users.sourceforge.net> The snd_pcm_suspend() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/oxygen/oxygen_lib.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Continue reading

ALSA: emu10k1: Delete an unnecessary check before the function call “kfree”

Author: Markus Elfring <elfring@users.sourceforge.net> The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/emu10k1/p16v.c | 7 ++—– 1 file changed, 2 insertions(+), 5 deletions(-)   diff …

Continue reading

sound: oss: Deletion of unnecessary checks before the function call “vfree”

Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/oss/pss.c | 2 +- sound/oss/trix.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)   diff –git …

Continue reading

ALSA: seq: Deletion of unnecessary checks before the function call “snd_midi_event_free”

Author: Markus Elfring <elfring@users.sourceforge.net> The snd_midi_event_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/core/seq/oss/seq_oss_midi.c | 6 ++—- sound/core/seq/seq_midi.c | 3 +– 2 files changed, 3 insertions(+), …

Continue reading

mac802154: fix kbuild test robot warning

Author: Alexander Aring <alex.aring@gmail.com> This patch fixs the following kbuild test robot warning: coccinelle warnings: (new ones prefixed by >>) >> net/mac802154/cfg.c:53:1-3: WARNING: PTR_ERR_OR_ZERO can be used Signed-off-by: Alexander Aring Signed-off-by: Marcel Holtmann — net/mac802154/cfg.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-)   diff –git a/net/mac802154/cfg.c b/net/mac802154/cfg.c index 7d31da5..5d9f68c 100644 — a/net/mac802154/cfg.c …

Continue reading

ath10k: fix error return code

Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …

Continue reading

net: axienet: fix error return code

Author: Julia Lawall <julia.lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …

Continue reading

adm8211: fix error return code

Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …

Continue reading