Category: Linux

Staging: rtl8192u: Fix space issues before ‘(‘ and after ‘)’

Author: Haneen Mohammed <hamohammed.sa@gmail.com> Space is required before the open and after the close parenthesis. This patch adds space after ‘if’ and before ‘{‘. This was done with the help of the following Coccinelle script: @r@ expression E; position p1,p2,p3; @@ if@p1 (E) @p3{@p2 … } @script:python@ p1

Staging: rtl8192u: Add space before open parenthesis

Author: Haneen Mohammed <hamohammed.sa@gmail.com> Space is required before the open parenthesis. This patch adds space after if to address that issue. This was done with the help of the following Coccinelle script: @r@ position p1,p2; @@ if@p1 (@p2 …) { … } @script:python@ p1

usb: host/sl811-hcd: fix platform_no_drv_owner.cocci warnings

Author: kbuild test robot <fengguang.wu@intel.com> drivers/usb/host/sl811-hcd.c:1812:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu Acked-by: Lad, Prabhakar Signed-off-by: Greg Kroah-Hartman — drivers/usb/host/sl811-hcd.c | 1 – 1 file changed, 1 deletion(-)   diff –git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c …

Continue reading

Staging: rtl8188eu: replace kzalloc and memcpy by kmemdup

Author: Niranjan Dighe <niranjan.dighe@gmail.com> This was generated by ‘make coccicheck’ using scripts at scripts/coccinelle/api/memdup.cocci. Signed-off-by: Niranjan Dighe Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++— 1 file changed, 2 insertions(+), 3 deletions(-)   diff –git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c index 86d955f..be9e34a 100644 — a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c @@ -5431,15 +5431,14 @@ u8 set_tx_beacon_cmd(struct adapter *padapter) goto exit; } …

Continue reading

cx82310_eth: fix semicolon.cocci warnings

Author: Wu Fengguang <fengguang.wu@intel.com> drivers/net/usb/cx82310_eth.c:175:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Ondrej Zary Signed-off-by: Fengguang Wu Signed-off-by: David S. Miller — drivers/net/usb/cx82310_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/net/usb/cx82310_eth.c b/drivers/net/usb/cx82310_eth.c index 1762ad3..e221bfc 100644 — a/drivers/net/usb/cx82310_eth.c +++ b/drivers/net/usb/cx82310_eth.c @@ -172,7 +172,7 @@ static int cx82310_bind(struct usbnet …

Continue reading

Staging: iio: use the BIT macro in .h files

Author: Haneen Mohammed <hamohammed.sa@gmail.com> This patch replace bit shifting on 1, 2, and 3 with the BIT(x) macro. Issue addressed by checkpatch.pl with –strict flag. This was done with the help of Coccninelle: @r1@ constant int g; @@ ( 0

Staging: iio: Simplify NULL pointer condition

Author: Cristina Opriceana <cristina.opriceana@gmail.com> Replace NULL comparrison with its shorter form. Done with coccinelle: @replace_rule@ expression e; @@ -e == NULL + !e Signed-off-by: Cristina Opriceana Signed-off-by: Greg Kroah-Hartman — drivers/staging/iio/magnetometer/hmc5843_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/staging/iio/magnetometer/hmc5843_core.c b/drivers/staging/iio/magnetometer/hmc5843_core.c index 90cc18b..6befa6f 100644 — a/drivers/staging/iio/magnetometer/hmc5843_core.c +++ b/drivers/staging/iio/magnetometer/hmc5843_core.c @@ -579,7 …

Continue reading

staging: vt6655: remove deprecated use of pci api

Author: Quentin Lambert <lambert.quentin@gmail.com> Replace occurences of the pci api by appropriate call to the dma api. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @deprecated@ idexpression id; position p; @@ ( pci_dma_supported@p ( id, …) | pci_alloc_consistent@p ( id, …) ) @bad1@ idexpression id; position deprecated.p; @@ …

Continue reading

Staging: media: replace pr_* with dev_*

Author: Haneen Mohammed <hamohammed.sa@gmail.com> This patch replace pr_err/pr_info with dev_err/dev_infi, when appropriate device structure is found. Issues found using the following Coccinelle script. pr_err/dev_err was substituted with pr_info/dev_info in the later case. @r exists@ identifier f, s, i; position p; @@ f(…,struct s *i,…) { } @rr@ identifier r.s, s2, fld; @@ struct s { …

Continue reading

Staging: gdm724x: replace pr_* with dev_*

Author: Haneen Mohammed <hamohammed.sa@gmail.com> This patch replace pr_err/pr_info with dev_err/dev_info, when appropriate device structure is found. Issue found and resolved using the following Coccinelle script. pr_err/dev_err was substituted with pr_info/dev_info in the later case. @r exists@ identifier f, s, i; position p; @@ f(…,struct s *i,…) { } @rr@ identifier r.s, s2, fld; @@ struct …

Continue reading