Quentin LAMBERT
Author's posts
Aug 20 2015
PCI: dra7xx: Remove unneeded use of IS_ERR_VALUE()
Author: Fabio Estevam <fabio.estevam@freescale.com> There is no need to use the IS_ERR_VALUE() macro for checking the return value from pm_runtime_* functions. Test for a negative pm_runtime_get_sync() return value instead of using IS_ERR_VALUE(). The semantic patch that makes this change is available in scripts/coccinelle/api/pm_runtime.cocci. Signed-off-by: Fabio Estevam Signed-off-by: Bjorn Helgaas CC: Kishon Vijay Abraham I — …
Aug 19 2015
[media] media: use entity.graph_obj.mdev instead of .parent
Author: Javier Martinez Canillas <javier@osg.samsung.com> The struct media_entity has a .parent field that stores a pointer to the parent struct media_device. But recently a media_gobj was embedded into the entities and since struct media_gojb already has a pointer to a struct media_device in the .mdev field, the .parent field becomes redundant and can be removed. …
Aug 18 2015
net: phy: fix semicolon.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> drivers/net/phy/smsc.c:127:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Igor Plyatov Signed-off-by: Fengguang Wu Signed-off-by: David S. Miller — drivers/net/phy/smsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index d64f016..70b0895 100644 — a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -124,7 +124,7 @@ static int lan87xx_read_status(struct …
Aug 17 2015
scatterlist: use sg_phys()
Author: Dan Williams <dan.j.williams@intel.com> Coccinelle cleanup to replace open coded sg to physical address translations. This is in preparation for introducing scatterlists that reference __pfn_t. // sg_phys.cocci: convert usage page_to_phys(sg_page(sg)) to sg_phys(sg) // usage: make coccicheck COCCI=sg_phys.cocci MODE=patch virtual patch @@ struct scatterlist *sg; @@ – page_to_phys(sg_page(sg)) + sg->offset + sg_phys(sg) @@ struct scatterlist *sg; …
Aug 15 2015
rtlwifi: rtl8192ee: fix semicolon.cocci warnings
Author: Wu Fengguang <fengguang.wu@intel.com> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:856:2-3: Unneeded semicolon drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:492:3-4: Unneeded semicolon drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:452:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Larry Finger Signed-off-by: Fengguang Wu Signed-off-by: Larry Finger Signed-off-by: Kalle Valo — drivers/net/wireless/rtlwifi/rtl8192ee/phy.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c b/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c index a863a44..018340a 100644 — a/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ee/phy.c …
Aug 14 2015
crypto: amcc – Do a NULL check for pointer
Author: Fabio Estevam <fabio.estevam@freescale.com> Compare pointer-typed values to NULL rather than 0. The semantic patch that makes this change is available in scripts/coccinelle/null/badzero.cocci Signed-off-by: Fabio Estevam Signed-off-by: Herbert Xu — drivers/crypto/amcc/crypto4xx_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 3b28e8c..192a8fa 100644 — a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1113,7 …
Aug 14 2015
ARM: rockchip: pm: Fix PTR_ERR() argument
Author: Fabio Estevam <fabio.estevam@freescale.com> PTR_ERR should access the value just tested by IS_ERR. The semantic patch that makes this change is available in scripts/coccinelle/tests/odd_ptr_err.cocci. Signed-off-by: Fabio Estevam Reviewed-by: Matthias Brugger Signed-off-by: Heiko Stuebner — arch/arm/mach-rockchip/pm.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) diff –git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c index 156cd23..bee8c80 100644 — a/arch/arm/mach-rockchip/pm.c …
Aug 14 2015
pinctrl: imx6ul: Remove .owner field
Author: Fabio Estevam <fabio.estevam@freescale.com> platform_driver does not need to set an owner as it will be populated by the driver core. The semantic patch that makes this change is available in scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam Signed-off-by: Linus Walleij — drivers/pinctrl/freescale/pinctrl-imx6ul.c | 1 – 1 file changed, 1 deletion(-) diff –git a/drivers/pinctrl/freescale/pinctrl-imx6ul.c b/drivers/pinctrl/freescale/pinctrl-imx6ul.c index b182be7..08e7576 …
Aug 13 2015
gpio: extraxfs: fix returnvar.cocci warnings
Author: Julia Lawall <julia.lawall@lip6.fr> Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall Signed-off-by: Linus Walleij — drivers/gpio/gpio-etraxfs.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/gpio/gpio-etraxfs.c b/drivers/gpio/gpio-etraxfs.c index 2ffcd9f..ca33bda 100644 — a/drivers/gpio/gpio-etraxfs.c +++ b/drivers/gpio/gpio-etraxfs.c @@ -292,7 +292,6 @@ static int etraxfs_gpio_irq_request_resources(struct …
Aug 13 2015
wil6210: match wait_for_completion_timeout return type
Author: Nicholas Mc Guire <hofrat@osadl.org> Return type of wait_for_completion_timeout is unsigned long not int. As remain is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/wil6210/wmi.c:827 int return assigned to unsigned long Patch was …