Quentin LAMBERT
Author's posts
Sep 23 2012
edac_mc: fix messy kfree calls in the error path
Author: Fengguang Wu <fengguang.wu@intel.com> coccinelle warns about: + drivers/edac/edac_mc.c:429:9-23: ERROR: reference preceded by free on line 429 421 if (mci->csrows) { > 422 for (chn = 0; chn < tot_channels; chn++) { 423 csr = mci->csrows[chn]; 424 if (csr) { > 425 for (chn = 0; chn < tot_channels; chn++) 426 kfree(csr->channels[chn]); 427 kfree(csr); 428 …
Sep 20 2012
staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rtsx.c
Author: YAMANE Toshiaki <yamanetoshi@gmail.com> fixed some coccinelle warnings. + drivers/staging/rts_pstor/rtsx.c:397:16-19: ERROR: dev is NULL but dereferenced. drivers/staging/rts_pstor/rtsx.c:447:16-19: ERROR: dev is NULL but dereferenced. drivers/staging/rts_pstor/rtsx.c:358:16-19: ERROR: dev is NULL but dereferenced. Signed-off-by: YAMANE Toshiaki Signed-off-by: Greg Kroah-Hartman — drivers/staging/rts_pstor/rtsx.c | 18 +++————— 1 file changed, 3 insertions(+), 15 deletions(-) diff –git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c index 213829e..afe9c2e …
Sep 19 2012
USB: serial: fix up bug with missing {}
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org> As reported by Fengguang: FYI, coccinelle warns about drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code on line 1416 vim +1415 drivers/usb/serial/usb-serial.c 1412 /* we only set the reset_resume field if the serial_driver has one */ 1413 for (sd = serial_drivers; *sd; ++sd) { 1414 if ((*sd)->reset_resume) > 1415 udriver->reset_resume = usb_serial_reset_resume; > …
Sep 19 2012
mfd: Use IRQF_ONESHOT for max8925
Author: Fengguang Wu <fengguang.wu@intel.com> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT. Signed-off-by: Fengguang Wu Signed-off-by: Samuel Ortiz — drivers/mfd/max8925-core.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/mfd/max8925-core.c b/drivers/mfd/max8925-core.c index f2ff31f..e25a242 100644 — a/drivers/mfd/max8925-core.c +++ b/drivers/mfd/max8925-core.c @@ -547,7 +547,7 @@ static …
Sep 19 2012
staging: ozwpan: compare pointer to NULL rather than 0
Author: Fengguang Wu <fengguang.wu@intel.com> Generated by: scripts/coccinelle/null/badzero.cocci Signed-off-by: Fengguang Wu Signed-off-by: Greg Kroah-Hartman — drivers/staging/ozwpan/ozcdev.c | 14 +++++++——- 1 file changed, 7 insertions(+), 7 deletions(-) diff –git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 758ce0a..64913ae 100644 — a/drivers/staging/ozwpan/ozcdev.c +++ b/drivers/staging/ozwpan/ozcdev.c @@ -104,10 +104,10 @@ ssize_t oz_cdev_read(struct file *filp, char __user *buf, size_t count, if (pd) oz_pd_get(pd); spin_unlock_bh(&g_cdev.lock); – …
Sep 19 2012
mfd: Use IRQF_ONESHOT for twl6040
Author: Fengguang Wu <fengguang.wu@intel.com> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT. Signed-off-by: Fengguang Wu Acked-by: Peter Ujfalusi Signed-off-by: Samuel Ortiz — drivers/mfd/twl6040-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/mfd/twl6040-core.c b/drivers/mfd/twl6040-core.c index 3dca5c1..348e1de 100644 — a/drivers/mfd/twl6040-core.c +++ b/drivers/mfd/twl6040-core.c @@ -584,7 …
Sep 19 2012
mfd: Use IRQF_ONESHOT for 88pm860x
Author: Fengguang Wu <fengguang.wu@intel.com> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT. Signed-off-by: Fengguang Wu Signed-off-by: Samuel Ortiz — drivers/mfd/88pm860x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c index 0c01d74..ad966c4 100644 — a/drivers/mfd/88pm860x-core.c +++ b/drivers/mfd/88pm860x-core.c @@ -659,7 +659,7 @@ static …
Sep 18 2012
ARM: davinci: board-dm646x-evm.c: Remove unecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> Found by http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Sekhar Nori — arch/arm/mach-davinci/board-dm646x-evm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c index 1dbf85b..9211e88 100644 — a/arch/arm/mach-davinci/board-dm646x-evm.c +++ b/arch/arm/mach-davinci/board-dm646x-evm.c @@ -194,7 +194,7 @@ static int evm_led_setup(struct i2c_client *client, int gpio, while (ngpio–) { leds->gpio = …
Sep 18 2012
arch/x86: Remove unecessary semicolons
Author: Peter Senna Tschudin <peter.senna@gmail.com> Found by http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Cc: avi@redhat.com Cc: mtosatti@redhat.com Cc: a.p.zijlstra@chello.nl Cc: rusty@rustcorp.com.au Cc: masami.hiramatsu.pt@hitachi.com Cc: suresh.b.siddha@intel.com Cc: joerg.roedel@amd.com Cc: agordeev@redhat.com Cc: yinghai@kernel.org Cc: bhelgaas@google.com Cc: liuj97@gmail.com Link: http://lkml.kernel.org/r/1347986174-30287-7-git-send-email-peter.senna@gmail.com Signed-off-by: Ingo Molnar — arch/x86/kernel/alternative.c | 4 ++– arch/x86/kernel/apic/apic.c | 2 +- arch/x86/kvm/vmx.c | 2 +- arch/x86/pci/mmconfig-shared.c | 2 …
Sep 18 2012
arch/arm/plat-omap/omap-pm-noop.c: Remove unecessary semicolon
Author: Peter Senna Tschudin <peter.senna@gmail.com> Found by http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin Signed-off-by: Tony Lindgren — arch/arm/plat-omap/omap-pm-noop.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-) diff –git a/arch/arm/plat-omap/omap-pm-noop.c b/arch/arm/plat-omap/omap-pm-noop.c index 9f64133..9722f41 100644 — a/arch/arm/plat-omap/omap-pm-noop.c +++ b/arch/arm/plat-omap/omap-pm-noop.c @@ -38,7 +38,7 @@ int omap_pm_set_max_mpu_wakeup_lat(struct device *dev, long t) if (!dev || t < -1) …