Quentin LAMBERT
Author's posts
Nov 23 2014
video: fbdev-SIS: Deletion of unnecessary checks before the function call “pci_dev_put”
Author: Markus Elfring <elfring@users.sourceforge.net> The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen — drivers/video/fbdev/sis/sis_main.c | 14 +++++——— 1 file changed, 5 insertions(+), 9 deletions(-) diff …
Nov 23 2014
video: smscufx: Deletion of unnecessary checks before the function call “vfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen — drivers/video/fbdev/smscufx.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-) diff –git a/drivers/video/fbdev/smscufx.c b/drivers/video/fbdev/smscufx.c index d513ed6..9279e5f …
Nov 23 2014
PCI/MSI: Rename mask/unmask_msi_irq treewide
Author: Thomas Gleixner <tglx@linutronix.de> The PCI/MSI irq chip callbacks mask/unmask_msi_irq have been renamed to pci_msi_mask/unmask_irq to mark them PCI specific. Rename all usage sites. The conversion helper functions are kept around to avoid conflicts in next and will be removed after merging into mainline. Coccinelle assisted conversion. No functional change. Signed-off-by: Thomas Gleixner Cc: Bjorn …
Nov 23 2014
video: udlfb: Deletion of unnecessary checks before the function call “vfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen — drivers/video/fbdev/udlfb.c | 9 +++—— 1 file changed, 3 insertions(+), 6 deletions(-) diff –git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c index 046d51d..ff2b873 …
Nov 23 2014
video: uvesafb: Deletion of an unnecessary check before the function call “uvesafb_free”
Author: Markus Elfring <elfring@users.sourceforge.net> The uvesafb_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen — drivers/video/fbdev/uvesafb.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 22 2014
video: fbdev-LCDC: Deletion of an unnecessary check before the function call “vfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen — drivers/video/fbdev/sh_mobile_lcdcfb.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index 2bcc84a..cfde21d …
Nov 22 2014
PowerPC-83xx: Deletion of an unnecessary check before the function call “of_node_put”
Author: Markus Elfring <elfring@users.sourceforge.net> The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Scott Wood — arch/powerpc/platforms/83xx/usb.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 22 2014
usb: dwc3: return error code from the most recent call
Author: Julia Lawall <Julia.Lawall@lip6.fr> Copy-paste error from the previous block of error handling code. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,e1; @@ if (IS_ERR(e)) { … ( ret = PTR_ERR(e); | * ret = PTR_ERR(e1); ) … return ret; } // Signed-off-by: Julia …
Nov 22 2014
dmaengine: ste_dma40: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Nov 22 2014
solos-pci: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …