Quentin LAMBERT
Author's posts
Mar 05 2015
Input: tc3589x-keypad – set IRQF_ONESHOT flag to ensure IRQ request
Author: Valentin Rothberg <Valentin.Rothberg@lip6.fr> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (“genirq: Reject bogus threaded irq requests”) threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. Currently, plat->irqtype is only set to IRQF_TRIGGER_FALLING. This patch sets the ONESHOT flag directly in request_threaded_irq() to enforce the flag without being affected by future …
Mar 04 2015
ASoC: tegra: fix platform_no_drv_owner.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> sound/soc/tegra/tegra_rt5677.c:334:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Anatol Pomozov Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/tegra/tegra_rt5677.c | 1 – 1 file changed, 1 deletion(-) diff –git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c …
Mar 04 2015
Staging: drivers: Bool initializations should use true/false
Author: Cristina Opriceana <cristina.opriceana@gmail.com> This patch replaces bool initializations of 1/0 with true/false in order to increase readability and respect the standards. Warning found by coccinelle. Signed-off-by: Cristina Opriceana Signed-off-by: Greg Kroah-Hartman — drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 4 ++– drivers/staging/lustre/lustre/llite/llite_mmap.c | 2 +- drivers/staging/rtl8192u/ieee80211/dot11d.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 4 ++– drivers/staging/rtl8192u/r8192U_core.c | …
Mar 04 2015
staging: rts5208: Convert variable from int to bool and propagate the change to function parameters
Author: Quentin Lambert <lambert.quentin@gmail.com> This patch convert local variables declared as int into booleans. It also propagates the conversion when these variables were used as function parameters. Coccinelle was used to generate this patch. Signed-off-by: Quentin Lambert Signed-off-by: Greg Kroah-Hartman — drivers/staging/rts5208/ms.c | 9 ++++—- drivers/staging/rts5208/ms.h | 2 +- drivers/staging/rts5208/rtsx_scsi.c | 7 +++— drivers/staging/rts5208/sd.c | …
Mar 04 2015
staging: rts5208: Convert non-returned local variable to boolean when relevant
Author: Quentin Lambert <lambert.quentin@gmail.com> This patch was produced using Coccinelle. A simplified version of the semantic patch is: @r exists@ identifier f; local idexpression u8 x; identifier xname; @@ f(…) { …when any ( x@xname = 1; | x@xname = 0; ) …when any } @bad exists@ identifier r.f; local idexpression u8 r.x expression e1 …
Mar 04 2015
Staging: rtl8188eu: Remove redundant local variable
Author: Somya Anand <somyaanand214@gmail.com> This patch removes a redundant variable “raid” and adds inline return statements. This issue is identified by the following coccinelle script: @@ expression ret; identifier f; @@ -ret = +return f(…); -return ret; Signed-off-by: Somya Anand Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 24 +++++++—————– 1 file changed, 7 insertions(+), 17 deletions(-) …
Mar 04 2015
irqf_oneshot.cocci: add check of devm_request_threaded_irq()
Author: Valentin Rothberg <valentinrothberg@gmail.com> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (“genirq: Reject bogus threaded irq requests”) threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. Until now, this coccinelle script only checked request_threaded_irq(). However, the counterpart devm function (see kernel/irq/devres.c) is also affected by the missing flag which can be …
Mar 04 2015
staging: rtl8712: replace memset(x,0,ETH_ALEN)
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The aforementioned function replaces memset. In addition, linux/etherdevice.h was included as a header since it is the file that defines the inline function eth_zero_addr(). The changes were carried out using the following coccinelle …
Mar 04 2015
staging: rtl8188eu: replace memset(x,0,ETH_ALEN)
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The aforementioned function replaces memset. In addition, linux/etherdevice.h was included as a header since it is the file that define the inline function eth_zero_addr(). The changes were carried out using the following coccinelle …
Mar 04 2015
staging: unisys: virthba: remove extra parentheses around left bit shift operations
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise left shift operations. The case handled is when resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1