Btrfs: fix possible memory leak in scrub_setup_recheck_block()

Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

bbio has been malloced in btrfs_map_block() and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun

---
 fs/btrfs/scrub.c | 1 +
 1 file changed, 1 insertion(+)
 
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index b223620..4e9eafe 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -1029,6 +1029,7 @@ static int scrub_setup_recheck_block(struct scrub_dev *sdev,
 				spin_lock(&sdev->stat_lock);
 				sdev->stat.malloc_errors++;
 				spin_unlock(&sdev->stat_lock);
+				kfree(bbio);
 				return -ENOMEM;
 			}
 			sblock->page_count++;

Btrfs: fix possible memory leak in scrub_setup_recheck_block()

qlambert

Archives

Posts by Subject