drm/msm/dsi: Delete an unnecessary check before the function call “dsi_destroy”
Author: Markus Elfring <elfring@users.sourceforge.net>
The dsi_destroy() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/dsi/dsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c
index 1f2561e..dc4f38f 100644
--- a/drivers/gpu/drm/msm/dsi/dsi.c
+++ b/drivers/gpu/drm/msm/dsi/dsi.c
@@ -110,9 +110,7 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev)
return msm_dsi;
fail:
- if (msm_dsi)
- dsi_destroy(msm_dsi);
-
+ dsi_destroy(msm_dsi);
return ERR_PTR(ret);
} |
---
drivers/gpu/drm/msm/dsi/dsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c
index 1f2561e..dc4f38f 100644
--- a/drivers/gpu/drm/msm/dsi/dsi.c
+++ b/drivers/gpu/drm/msm/dsi/dsi.c
@@ -110,9 +110,7 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev)
return msm_dsi;
fail:
- if (msm_dsi)
- dsi_destroy(msm_dsi);
-
+ dsi_destroy(msm_dsi);
return ERR_PTR(ret);
}