USB: fusbh200-hcd.c: move assignment out of if () block

Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Sergei Shtylyov 
Acked-by: Alan Stern 
CC: Petr Mladek 
CC: Randy Dunlap 
CC: Masanari Iida 
Signed-off-by: Greg Kroah-Hartman 
Reviewed-by: Felipe Balbi

---
 drivers/usb/host/fusbh200-hcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
 
diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c
index 00e492e..1fd8718 100644
--- a/drivers/usb/host/fusbh200-hcd.c
+++ b/drivers/usb/host/fusbh200-hcd.c
@@ -499,7 +499,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf)
 	unsigned		i;
 	__hc32			tag;
 
-	if (!(seen = kmalloc (DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC)))
+	seen = kmalloc(DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC);
+	if (!seen)
 		return 0;
 	seen_count = 0;

USB: fusbh200-hcd.c: move assignment out of if () block

qlambert

Archives

Posts by Subject