Author: Jan Kiszka <jan.kiszka@siemens.com> The code was already properly aligned, now also add the braces to avoid that err is checked even if alloc_apic_access_page didn’t run and change it. Found via Coccinelle by Fengguang Wu. Signed-off-by: Jan Kiszka Signed-off-by: Gleb Natapov — arch/x86/kvm/vmx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff …
Format: Quote
Feb 28 2013
hlist: drop the node parameter from iterators
Author: Sasha Levin <sasha.levin@oracle.com> I’m not sure why, but the hlist for each entry iterators were conceived list_for_each_entry(pos, head, member) The hlist ones were greedy and wanted an extra parameter: hlist_for_each_entry(tpos, pos, head, member) Why did they need an extra pos parameter? I’m not quite sure. Not only they don’t really need it, it also …
Aug 12 2011
staging:iio:addac:adt7316 make interrupt mask sane.
Author: Jonathan Cameron <jic23@cam.ac.uk> Coccinelle found this one. I’m not certain what the intent is, but this fix makes no functional changes. Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman — drivers/staging/iio/addac/adt7316.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c index 637316f..c828b6f 100644 — a/drivers/staging/iio/addac/adt7316.c +++ b/drivers/staging/iio/addac/adt7316.c @@ -203,7 +203,7 …
Mar 21 2011
sched/rt: Use schedule_preempt_disabled()
Author: Thomas Gleixner <tglx@linutronix.de> Coccinelle based conversion. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra Link: http://lkml.kernel.org/n/tip-24swm5zut3h9c4a6s46x8rws@git.kernel.org Signed-off-by: Ingo Molnar — arch/arm/kernel/process.c | 4 +— arch/avr32/kernel/process.c | 4 +— arch/blackfin/kernel/process.c | 4 +— arch/cris/kernel/process.c | 4 +— arch/frv/kernel/process.c | 4 +— arch/h8300/kernel/process.c | 4 +— arch/ia64/kernel/process.c | 4 +— arch/m32r/kernel/process.c | 4 +— arch/m68k/kernel/process_mm.c | 4 +— …
Mar 09 2010
Staging: otus: drop redundant memset
Author: Julia Lawall <julia@diku.dk> The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2,e3,e4; @@ – memset(e1,e2,e3); memcpy(e1,e4,e3); // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/otus/wwrap.c | 1 – 1 file changed, …
Jan 10 2010
firewire: make PCI device id constant
Author: Németh Márton <nm127@freemail.hu> The id_table field of the struct pci_driver is constant in so it is worth to make pci_table also constant. Found with Coccinelle. Signed-off-by: Márton Németh Cc: Julia Lawall Cc: cocci@diku.dk Signed-off-by: Stefan Richter stefanr@s5r6.in-berlin.de> (changelog) — drivers/firewire/ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/firewire/ohci.c …
Oct 06 2009
omap: iovmm: Add missing mutex_unlock
Author: Daniel Walker <dwalker@fifo99.com> I was using Coccinelle with the mutex_unlock semantic patch, and it unconvered this problem. It appears to be a valid missing unlock issue. This change should correct it by moving the unlock below the label. This patch is against the mainline kernel. Cc: Julia Lawall Cc: Hiroshi DOYU Signed-off-by: Daniel Walker …
Sep 12 2009
x86: apic: Convert BUG() to BUG_ON()
Author: Daniel Walker <dwalker@fifo99.com> This was done using Coccinelle’s BUG_ON semantic patch. Signed-off-by: Daniel Walker Cc: Julia Lawall LKML-Reference: Signed-off-by: Ingo Molnar — arch/x86/kernel/apic/apic.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 159740d..79e5b92 100644 — a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1196,8 +1196,7 @@ void __cpuinit setup_local_APIC(void) * Double-check …
Aug 28 2008
Blackfin arch: sram: use ‘unsigned long’ for irqflags
Author: Vegard Nossum <vegard.nossum@gmail.com> Using just ‘unsigned’ will make flags an unsigned int. While this is arguably not an error on blackfin where sizeof(int) == sizeof(long), the patch is still justified on the grounds of principle. The patch was generated using the Coccinelle semantic patch framework. Cc: Julia Lawall Cc: Alexey Dobriyan Signed-off-by: Vegard Nossum …
Aug 06 2008
au1000_eth: use ‘unsigned long’ for irqflags
Author: Vegard Nossum <vegard.nossum@gmail.com> The patch was generated using the Coccinelle semantic patch framework. Cc: Julia Lawall Cc: Alexey Dobriyan Cc: Jeff Garzik Signed-off-by: Vegard Nossum Signed-off-by: Jeff Garzik — drivers/net/au1000_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index cb8be49..5ee1b05 100644 — a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c @@ -807,7 …
