Apr 30 2015

staging: lustre: fix ifnullfree.cocci warnings 

Author: kbuild test robot <fengguang.wu@intel.com>

drivers/staging/lustre/lustre/lov/lov_request.c:74:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Julia Lawall 
Signed-off-by: Fengguang Wu 
Signed-off-by: Greg Kroah-Hartman 

---
 drivers/staging/lustre/lustre/lov/lov_request.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 
diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c
index 0a8cdbe..f6e1314 100644
--- a/drivers/staging/lustre/lustre/lov/lov_request.c
+++ b/drivers/staging/lustre/lustre/lov/lov_request.c
@@ -70,8 +70,7 @@ void lov_finish_set(struct lov_request_set *set)
 			OBDO_FREE(req->rq_oi.oi_oa);
 		if (req->rq_oi.oi_md)
 			OBD_FREE_LARGE(req->rq_oi.oi_md, req->rq_buflen);
-		if (req->rq_oi.oi_osfs)
-			kfree(req->rq_oi.oi_osfs);
+		kfree(req->rq_oi.oi_osfs);
 		kfree(req);
 	}

qlambert