Feb 12 2016

staging: goldfish: goldfish_nand: Return correct error code 

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com>

The return value of devm_kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//
@@
expression *e;
@@

e = devm_kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//

The single call site does not perform any checks on the return value, hence
no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla 
Signed-off-by: Greg Kroah-Hartman 

---
 drivers/staging/goldfish/goldfish_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c
index 623353db5..5c4f61c 100644
--- a/drivers/staging/goldfish/goldfish_nand.c
+++ b/drivers/staging/goldfish/goldfish_nand.c
@@ -290,7 +290,7 @@ static int nand_setup_cmd_params(struct platform_device *pdev,
 	nand->cmd_params = devm_kzalloc(&pdev->dev,
 					sizeof(struct cmd_params), GFP_KERNEL);
 	if (!nand->cmd_params)
-		return -1;
+		return -ENOMEM;
 
 	paddr = __pa(nand->cmd_params);
 	writel((u32)(paddr >> 32), base + NAND_CMD_PARAMS_ADDR_HIGH);

qlambert