Author: Ezequiel Garcia <firstname.lastname@example.org>
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
struct struct_name to;
struct struct_name from;
-memcpy(&(to), &(from), E);
+to = from;
Signed-off-by: Peter Senna Tschudin
Signed-off-by: Ezequiel Garcia
Signed-off-by: Mauro Carvalho Chehab
drivers/media/tuners/tuner-xc2028.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/tuners/tuner-xc2028.c b/drivers/media/tuners/tuner-xc2028.c
index 7bcb6b0..0945173 100644
@@ -870,7 +870,7 @@ check_device:
- memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw));
+ priv->cur_fw = new_fw;
* By setting BASE in cur_fw.type only after successfully loading all