HID: Drop NULL test on list_entry result

Author: Julia Lawall <julia@diku.dk>

list_entry, which is an alias for container_of, cannot return NULL, as
there is no way to add a NULL value to a doubly linked list.

A simplified version of the semantic match that findds this problem is as
follows:
(http://www.emn.fr/x-info/coccinelle/)

// 
@r@
expression x,E;
statement S1,S2;
position p,p1;
@@

*x = list_entry@p(...)
... when != x = E
*if@p1 (x == NULL) S1 else S2
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Jiri Kosina

---
 drivers/hid/hid-lgff.c | 5 -----
 1 file changed, 5 deletions(-)
 
diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
index 95835ea..987abeb 100644
--- a/drivers/hid/hid-lgff.c
+++ b/drivers/hid/hid-lgff.c
@@ -151,11 +151,6 @@ int lgff_init(struct hid_device* hid)
 
 	/* Check that the report looks ok */
 	report = list_entry(report_list->next, struct hid_report, list);
-	if (!report) {
-		err_hid("NULL output report");
-		return -1;
-	}
-
 	field = report->field[0];
 	if (!field) {
 		err_hid("NULL field");

HID: Drop NULL test on list_entry result

qlambert

Archives

Posts by Subject